Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(protocol squad) main branch pr #793

Draft
wants to merge 46 commits into
base: main
Choose a base branch
from
Draft

(protocol squad) main branch pr #793

wants to merge 46 commits into from

Conversation

leanmendoza
Copy link
Contributor

@leanmendoza leanmendoza commented Oct 17, 2023

  • Install the protocol-squad version in your scene by running npm i @dcl/sdk@protocol-squad in your scene root folder.
  • Run npm start to run Preview in Bevy

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2023

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: c9ef0d5
Status: ✅  Deploy successful!
Preview URL: https://f9fcefad.js-sdk-toolchain.pages.dev
Branch Preview URL: https://protocol-squad.js-sdk-toolchain.pages.dev

View logs

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: Patch coverage is 31.70732% with 84 lines in your changes missing coverage. Please review.

Project coverage is 64.25%. Comparing base (fd35f3f) to head (66d4cdc).
Report is 40 commits behind head on main.

Files Patch % Lines
...ckages/@dcl/sdk-commands/src/logic/dao-explorer.ts 20.73% 59 Missing and 6 partials ⚠️
...ages/@dcl/sdk-commands/src/commands/start/index.ts 5.00% 18 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
- Coverage   65.32%   64.25%   -1.08%     
==========================================
  Files         561      578      +17     
  Lines       17207    17984     +777     
  Branches     2171     2283     +112     
==========================================
+ Hits        11240    11555     +315     
- Misses       5593     6025     +432     
- Partials      374      404      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leanmendoza leanmendoza changed the title (do not merge) protocol squad: experimental main branch (protocol squad) main branch Nov 29, 2023
@leanmendoza leanmendoza changed the title (protocol squad) main branch (protocol squad) main branch pr Nov 29, 2023
@decentraland decentraland deleted a comment from github-actions bot May 7, 2024
* feat: add bevy in start command

* add locaiton

* only pass base url

* bevy versioning

* fix urls and rmdir

* do not open browser when dao-explorer is specified
* experimental cinematic camera

* skip test

* fix typo

* wip

* update protocol

* update bevy release

* update protocol
* bump protocol, update after build and add to react

* add customEntryPoint to sdk-commands start

* add wrap

* add to react

* update build

* update @dcl/protocol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant