fix: hero props (#36)

* fix: hero props * chore: test * chore: snapshots
decentraland · Mar 26, 2019 · 8d6a5d7 · 8d6a5d7
1 parent 063ebe5
commit 8d6a5d7
Show file tree

Hide file tree

Showing 71 changed files with 4 additions and 22 deletions.
diff --git a/src/components/Hero/Hero.tsx b/src/components/Hero/Hero.tsx
@@ -10,29 +10,29 @@ export type HeroProps = {
 }
 
 export class Hero extends React.PureComponent<HeroProps> {
-  static Header = ({ children }, ...props) => (
+  static Header = ({ children, ...props }) => (
     <Container>
       <Header className="hero-title" size="huge" {...props}>
         {children}
       </Header>
     </Container>
   )
 
-  static Description = ({ children }, ...props) => (
+  static Description = ({ children, ...props }) => (
     <Container>
       <Header className="hero-subtitle" {...props}>
         {children}
       </Header>
     </Container>
   )
 
-  static Content = ({ children }, ...props) => (
+  static Content = ({ children, ...props }) => (
     <div className="hero-content" {...props}>
       {children}
     </div>
   )
 
-  static Actions = ({ children }, ...props) => (
+  static Actions = ({ children, ...props }) => (
     <Container className="hero-actions" {...props}>
       {children}
     </Container>

diff --git a/test/coverage/__snapshots__/coverage.test.ts.snap b/test/coverage/__snapshots__/coverage.test.ts.snap
@@ -2523,7 +2523,6 @@ exports[`Decentraland UI - Coverage Tests Hero Left alignment 1`] = `
           className="ui container"
         >
           <div
-            0={Object {}}
             className="ui huge header hero-title"
           >
             Help us build Decentraland
@@ -2533,7 +2532,6 @@ exports[`Decentraland UI - Coverage Tests Hero Left alignment 1`] = `
           className="ui container"
         >
           <div
-            0={Object {}}
             className="ui header hero-subtitle"
           >
             Join the discussion
@@ -2579,7 +2577,6 @@ exports[`Decentraland UI - Coverage Tests Hero Text only 1`] = `
           className="ui container"
         >
           <div
-            0={Object {}}
             className="ui huge header hero-title"
           >
             Help us build Decentraland
@@ -2589,7 +2586,6 @@ exports[`Decentraland UI - Coverage Tests Hero Text only 1`] = `
           className="ui container"
         >
           <div
-            0={Object {}}
             className="ui header hero-subtitle"
           >
             Join the discussion
@@ -2635,7 +2631,6 @@ exports[`Decentraland UI - Coverage Tests Hero With actions 1`] = `
           className="ui container"
         >
           <div
-            0={Object {}}
             className="ui huge header hero-title"
           >
             Help us build Decentraland
@@ -2645,14 +2640,12 @@ exports[`Decentraland UI - Coverage Tests Hero With actions 1`] = `
           className="ui container"
         >
           <div
-            0={Object {}}
             className="ui header hero-subtitle"
           >
             Join the discussion
           </div>
         </div>
         <div
-          0={Object {}}
           className="ui container hero-actions"
         >
           <button
@@ -2702,7 +2695,6 @@ exports[`Decentraland UI - Coverage Tests Hero With content 1`] = `
           className="ui container"
         >
           <div
-            0={Object {}}
             className="ui huge header hero-title"
           >
             Help us build Decentraland
@@ -2712,14 +2704,12 @@ exports[`Decentraland UI - Coverage Tests Hero With content 1`] = `
           className="ui container"
         >
           <div
-            0={Object {}}
             className="ui header hero-subtitle"
           >
             Join the discussion
           </div>
         </div>
         <div
-          0={Object {}}
           className="hero-content"
         >
           <div
@@ -4764,7 +4754,6 @@ exports[`Decentraland UI - Coverage Tests Navbar With Overlay over Hero 1`] = `
           className="ui container"
         >
           <div
-            0={Object {}}
             className="ui huge header hero-title"
           >
             Help us build Decentraland
@@ -4774,14 +4763,12 @@ exports[`Decentraland UI - Coverage Tests Navbar With Overlay over Hero 1`] = `
           className="ui container"
         >
           <div
-            0={Object {}}
             className="ui header hero-subtitle"
           >
             Join the discussion
           </div>
         </div>
         <div
-          0={Object {}}
           className="hero-content"
         >
           <div
@@ -4969,7 +4956,6 @@ exports[`Decentraland UI - Coverage Tests Navbar With hero 1`] = `
           className="ui container"
         >
           <div
-            0={Object {}}
             className="ui huge header hero-title"
           >
             Help us build Decentraland
@@ -4979,14 +4965,12 @@ exports[`Decentraland UI - Coverage Tests Navbar With hero 1`] = `
           className="ui container"
         >
           <div
-            0={Object {}}
             className="ui header hero-subtitle"
           >
             Join the discussion
           </div>
         </div>
         <div
-          0={Object {}}
           className="hero-content"
         >
           <div
@@ -5614,7 +5598,6 @@ exports[`Decentraland UI - Coverage Tests Page Hero page 1`] = `
             className="ui container"
           >
             <div
-              0={Object {}}
               className="ui huge header hero-title"
             >
               ATLAS
@@ -5624,7 +5607,6 @@ exports[`Decentraland UI - Coverage Tests Page Hero page 1`] = `
             className="ui container"
           >
             <div
-              0={Object {}}
               className="ui header hero-subtitle"
             >
               Or something like that

diff --git a/...ts__/visual-test-ts-decentraland-ui-visual-tests-address-full-length-1-snap.png b/...ts__/visual-test-ts-decentraland-ui-visual-tests-address-full-length-1-snap.png
diff --git a/..._/visual-test-ts-decentraland-ui-visual-tests-address-in-a-paragraph-1-snap.png b/..._/visual-test-ts-decentraland-ui-visual-tests-address-in-a-paragraph-1-snap.png
diff --git a/...napshots__/visual-test-ts-decentraland-ui-visual-tests-address-plain-1-snap.png b/...napshots__/visual-test-ts-decentraland-ui-visual-tests-address-plain-1-snap.png
diff --git a/...pshots__/visual-test-ts-decentraland-ui-visual-tests-address-tooltip-1-snap.png b/...pshots__/visual-test-ts-decentraland-ui-visual-tests-address-tooltip-1-snap.png
diff --git a/..._/visual-test-ts-decentraland-ui-visual-tests-blockie-in-a-paragraph-1-snap.png b/..._/visual-test-ts-decentraland-ui-visual-tests-blockie-in-a-paragraph-1-snap.png
diff --git a/...snapshots__/visual-test-ts-decentraland-ui-visual-tests-button-basic-1-snap.png b/...snapshots__/visual-test-ts-decentraland-ui-visual-tests-button-basic-1-snap.png
diff --git a/...apshots__/visual-test-ts-decentraland-ui-visual-tests-button-primary-1-snap.png b/...apshots__/visual-test-ts-decentraland-ui-visual-tests-button-primary-1-snap.png
diff --git a/...snapshots__/visual-test-ts-decentraland-ui-visual-tests-button-sizes-1-snap.png b/...snapshots__/visual-test-ts-decentraland-ui-visual-tests-button-sizes-1-snap.png
diff --git a/...e_snapshots__/visual-test-ts-decentraland-ui-visual-tests-card-polls-1-snap.png b/...e_snapshots__/visual-test-ts-decentraland-ui-visual-tests-card-polls-1-snap.png
diff --git a/...snapshots__/visual-test-ts-decentraland-ui-visual-tests-field-action-1-snap.png b/...snapshots__/visual-test-ts-decentraland-ui-visual-tests-field-action-1-snap.png
diff --git a/...napshots__/visual-test-ts-decentraland-ui-visual-tests-field-address-1-snap.png b/...napshots__/visual-test-ts-decentraland-ui-visual-tests-field-address-1-snap.png
diff --git a/...apshots__/visual-test-ts-decentraland-ui-visual-tests-field-disabled-1-snap.png b/...apshots__/visual-test-ts-decentraland-ui-visual-tests-field-disabled-1-snap.png
diff --git a/..._snapshots__/visual-test-ts-decentraland-ui-visual-tests-field-error-1-snap.png b/..._snapshots__/visual-test-ts-decentraland-ui-visual-tests-field-error-1-snap.png
diff --git a/...napshots__/visual-test-ts-decentraland-ui-visual-tests-field-message-1-snap.png b/...napshots__/visual-test-ts-decentraland-ui-visual-tests-field-message-1-snap.png
diff --git a/...shots__/visual-test-ts-decentraland-ui-visual-tests-field-one-active-1-snap.png b/...shots__/visual-test-ts-decentraland-ui-visual-tests-field-one-active-1-snap.png
diff --git a/...hots__/visual-test-ts-decentraland-ui-visual-tests-field-placeholder-1-snap.png b/...hots__/visual-test-ts-decentraland-ui-visual-tests-field-placeholder-1-snap.png
diff --git a/...hots__/visual-test-ts-decentraland-ui-visual-tests-footer-controlled-1-snap.png b/...hots__/visual-test-ts-decentraland-ui-visual-tests-footer-controlled-1-snap.png
diff --git a/...ts__/visual-test-ts-decentraland-ui-visual-tests-footer-uncontrolled-1-snap.png b/...ts__/visual-test-ts-decentraland-ui-visual-tests-footer-uncontrolled-1-snap.png
diff --git a/.../visual-test-ts-decentraland-ui-visual-tests-header-menu-with-button-1-snap.png b/.../visual-test-ts-decentraland-ui-visual-tests-header-menu-with-button-1-snap.png
diff --git a/...s-decentraland-ui-visual-tests-header-menu-with-dropdown-and-stacked-1-snap.png b/...s-decentraland-ui-visual-tests-header-menu-with-dropdown-and-stacked-1-snap.png
diff --git a/...snapshots__/visual-test-ts-decentraland-ui-visual-tests-header-sizes-1-snap.png b/...snapshots__/visual-test-ts-decentraland-ui-visual-tests-header-sizes-1-snap.png
diff --git a/...ts__/visual-test-ts-decentraland-ui-visual-tests-hero-left-alignment-1-snap.png b/...ts__/visual-test-ts-decentraland-ui-visual-tests-hero-left-alignment-1-snap.png
diff --git a/...apshots__/visual-test-ts-decentraland-ui-visual-tests-hero-text-only-1-snap.png b/...apshots__/visual-test-ts-decentraland-ui-visual-tests-hero-text-only-1-snap.png
diff --git a/...hots__/visual-test-ts-decentraland-ui-visual-tests-hero-with-actions-1-snap.png b/...hots__/visual-test-ts-decentraland-ui-visual-tests-hero-with-actions-1-snap.png
diff --git a/...hots__/visual-test-ts-decentraland-ui-visual-tests-hero-with-content-1-snap.png b/...hots__/visual-test-ts-decentraland-ui-visual-tests-hero-with-content-1-snap.png
diff --git a/...__/visual-test-ts-decentraland-ui-visual-tests-language-icon-options-1-snap.png b/...__/visual-test-ts-decentraland-ui-visual-tests-language-icon-options-1-snap.png
diff --git a/...ts__/visual-test-ts-decentraland-ui-visual-tests-mana-in-a-paragraph-1-snap.png b/...ts__/visual-test-ts-decentraland-ui-visual-tests-mana-in-a-paragraph-1-snap.png
diff --git a/...e_snapshots__/visual-test-ts-decentraland-ui-visual-tests-mana-sizes-1-snap.png b/...e_snapshots__/visual-test-ts-decentraland-ui-visual-tests-mana-sizes-1-snap.png
diff --git a/...shots__/visual-test-ts-decentraland-ui-visual-tests-mana-total-voted-1-snap.png b/...shots__/visual-test-ts-decentraland-ui-visual-tests-mana-total-voted-1-snap.png
diff --git a/...apshots__/visual-test-ts-decentraland-ui-visual-tests-modal-closable-1-snap.png b/...apshots__/visual-test-ts-decentraland-ui-visual-tests-modal-closable-1-snap.png
diff --git a/...ts__/visual-test-ts-decentraland-ui-visual-tests-modal-custom-header-1-snap.png b/...ts__/visual-test-ts-decentraland-ui-visual-tests-modal-custom-header-1-snap.png
diff --git a/...e_snapshots__/visual-test-ts-decentraland-ui-visual-tests-modal-form-1-snap.png b/...e_snapshots__/visual-test-ts-decentraland-ui-visual-tests-modal-form-1-snap.png
diff --git a/...snapshots__/visual-test-ts-decentraland-ui-visual-tests-modal-simple-1-snap.png b/...snapshots__/visual-test-ts-decentraland-ui-visual-tests-modal-simple-1-snap.png
diff --git a/..._snapshots__/visual-test-ts-decentraland-ui-visual-tests-modal-small-1-snap.png b/..._snapshots__/visual-test-ts-decentraland-ui-visual-tests-modal-small-1-snap.png
diff --git a/...e_snapshots__/visual-test-ts-decentraland-ui-visual-tests-modal-tiny-1-snap.png b/...e_snapshots__/visual-test-ts-decentraland-ui-visual-tests-modal-tiny-1-snap.png
diff --git a/...snapshots__/visual-test-ts-decentraland-ui-visual-tests-navbar-agora-1-snap.png b/...snapshots__/visual-test-ts-decentraland-ui-visual-tests-navbar-agora-1-snap.png
diff --git a/...shots__/visual-test-ts-decentraland-ui-visual-tests-navbar-connected-1-snap.png b/...shots__/visual-test-ts-decentraland-ui-visual-tests-navbar-connected-1-snap.png
diff --git a/...hots__/visual-test-ts-decentraland-ui-visual-tests-navbar-connecting-1-snap.png b/...hots__/visual-test-ts-decentraland-ui-visual-tests-navbar-connecting-1-snap.png
diff --git a/...hots__/visual-test-ts-decentraland-ui-visual-tests-navbar-fullscreen-1-snap.png b/...hots__/visual-test-ts-decentraland-ui-visual-tests-navbar-fullscreen-1-snap.png
diff --git a/.../visual-test-ts-decentraland-ui-visual-tests-navbar-on-click-account-1-snap.png b/.../visual-test-ts-decentraland-ui-visual-tests-navbar-on-click-account-1-snap.png
diff --git a/...apshots__/visual-test-ts-decentraland-ui-visual-tests-navbar-sign-in-1-snap.png b/...apshots__/visual-test-ts-decentraland-ui-visual-tests-navbar-sign-in-1-snap.png
diff --git a/...ts__/visual-test-ts-decentraland-ui-visual-tests-navbar-sign-in-page-1-snap.png b/...ts__/visual-test-ts-decentraland-ui-visual-tests-navbar-sign-in-page-1-snap.png
diff --git a/...shots__/visual-test-ts-decentraland-ui-visual-tests-navbar-with-hero-1-snap.png b/...shots__/visual-test-ts-decentraland-ui-visual-tests-navbar-with-hero-1-snap.png
diff --git a/..._/visual-test-ts-decentraland-ui-visual-tests-navbar-with-menu-items-1-snap.png b/..._/visual-test-ts-decentraland-ui-visual-tests-navbar-with-menu-items-1-snap.png
diff --git a/...l-test-ts-decentraland-ui-visual-tests-navbar-with-overlay-over-hero-1-snap.png b/...l-test-ts-decentraland-ui-visual-tests-navbar-with-overlay-over-hero-1-snap.png
diff --git a/...s__/visual-test-ts-decentraland-ui-visual-tests-page-fullscreen-page-1-snap.png b/...s__/visual-test-ts-decentraland-ui-visual-tests-page-fullscreen-page-1-snap.png
diff --git a/...apshots__/visual-test-ts-decentraland-ui-visual-tests-page-hero-page-1-snap.png b/...apshots__/visual-test-ts-decentraland-ui-visual-tests-page-hero-page-1-snap.png
diff --git a/...sual-test-ts-decentraland-ui-visual-tests-page-menu-and-submenu-page-1-snap.png b/...sual-test-ts-decentraland-ui-visual-tests-page-menu-and-submenu-page-1-snap.png
diff --git a/...apshots__/visual-test-ts-decentraland-ui-visual-tests-page-menu-page-1-snap.png b/...apshots__/visual-test-ts-decentraland-ui-visual-tests-page-menu-page-1-snap.png
diff --git a/...hots__/visual-test-ts-decentraland-ui-visual-tests-page-regular-page-1-snap.png b/...hots__/visual-test-ts-decentraland-ui-visual-tests-page-regular-page-1-snap.png
diff --git a/...apshots__/visual-test-ts-decentraland-ui-visual-tests-popup-closable-1-snap.png b/...apshots__/visual-test-ts-decentraland-ui-visual-tests-popup-closable-1-snap.png
diff --git a/...apshots__/visual-test-ts-decentraland-ui-visual-tests-popup-on-click-1-snap.png b/...apshots__/visual-test-ts-decentraland-ui-visual-tests-popup-on-click-1-snap.png
diff --git a/...apshots__/visual-test-ts-decentraland-ui-visual-tests-popup-on-hover-1-snap.png b/...apshots__/visual-test-ts-decentraland-ui-visual-tests-popup-on-hover-1-snap.png
diff --git a/...pshots__/visual-test-ts-decentraland-ui-visual-tests-popup-positions-1-snap.png b/...pshots__/visual-test-ts-decentraland-ui-visual-tests-popup-positions-1-snap.png
diff --git a/...napshots__/visual-test-ts-decentraland-ui-visual-tests-radio-options-1-snap.png b/...napshots__/visual-test-ts-decentraland-ui-visual-tests-radio-options-1-snap.png
diff --git a/..._/visual-test-ts-decentraland-ui-visual-tests-segment-single-segment-1-snap.png b/..._/visual-test-ts-decentraland-ui-visual-tests-segment-single-segment-1-snap.png
diff --git a/...s__/visual-test-ts-decentraland-ui-visual-tests-segment-with-buttons-1-snap.png b/...s__/visual-test-ts-decentraland-ui-visual-tests-segment-with-buttons-1-snap.png
diff --git a/...ots__/visual-test-ts-decentraland-ui-visual-tests-segment-with-field-1-snap.png b/...ots__/visual-test-ts-decentraland-ui-visual-tests-segment-with-field-1-snap.png
diff --git a/...ual-test-ts-decentraland-ui-visual-tests-segment-with-field-disabled-1-snap.png b/...ual-test-ts-decentraland-ui-visual-tests-segment-with-field-disabled-1-snap.png
diff --git a/...ts__/visual-test-ts-decentraland-ui-visual-tests-segment-with-radios-1-snap.png b/...ts__/visual-test-ts-decentraland-ui-visual-tests-segment-with-radios-1-snap.png
diff --git a/...pshots__/visual-test-ts-decentraland-ui-visual-tests-sign-in-connect-1-snap.png b/...pshots__/visual-test-ts-decentraland-ui-visual-tests-sign-in-connect-1-snap.png
diff --git a/...hots__/visual-test-ts-decentraland-ui-visual-tests-sign-in-connected-1-snap.png b/...hots__/visual-test-ts-decentraland-ui-visual-tests-sign-in-connected-1-snap.png
diff --git a/...ots__/visual-test-ts-decentraland-ui-visual-tests-sign-in-connecting-1-snap.png b/...ots__/visual-test-ts-decentraland-ui-visual-tests-sign-in-connecting-1-snap.png
diff --git a/...napshots__/visual-test-ts-decentraland-ui-visual-tests-sign-in-error-1-snap.png b/...napshots__/visual-test-ts-decentraland-ui-visual-tests-sign-in-error-1-snap.png
diff --git a/...ots__/visual-test-ts-decentraland-ui-visual-tests-stats-poll-results-1-snap.png b/...ots__/visual-test-ts-decentraland-ui-visual-tests-stats-poll-results-1-snap.png
diff --git a/...ts__/visual-test-ts-decentraland-ui-visual-tests-stats-single-result-1-snap.png b/...ts__/visual-test-ts-decentraland-ui-visual-tests-stats-single-result-1-snap.png
diff --git a/..._snapshots__/visual-test-ts-decentraland-ui-visual-tests-table-polls-1-snap.png b/..._snapshots__/visual-test-ts-decentraland-ui-visual-tests-table-polls-1-snap.png
diff --git a/...pshots__/visual-test-ts-decentraland-ui-visual-tests-tabs-no-divider-1-snap.png b/...pshots__/visual-test-ts-decentraland-ui-visual-tests-tabs-no-divider-1-snap.png
diff --git a/...pshots__/visual-test-ts-decentraland-ui-visual-tests-tabs-one-active-1-snap.png b/...pshots__/visual-test-ts-decentraland-ui-visual-tests-tabs-one-active-1-snap.png