Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Image size #395

Merged
merged 3 commits into from
Aug 3, 2023
Merged

fix: Image size #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03458cc
fix: Image size
LautaroPetaccio Aug 3, 2023
bb6e527
fix: Remove link
LautaroPetaccio Aug 3, 2023
8acf38c
fix: Remove prop
LautaroPetaccio Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/components/AssetCard/AssetCard.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ const props: AssetCardProps = {
extraInformation: <span>1 listing</span>,
notForSale: false,
price: '10',
owners: '3 owners',
onClickCardURL: 'https://market.decentraland.zone'
owners: '3 owners'
}

storiesOf('AssetCard', module).add('Catalog', () => (
Expand Down
10 changes: 1 addition & 9 deletions src/components/AssetCard/AssetCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ export type AssetCardProps = {
notForSale: boolean
price?: string
owners?: string
onClickCardURL: string
}

export const AssetCard = (props: AssetCardProps) => {
Expand All @@ -27,19 +26,12 @@ export const AssetCard = (props: AssetCardProps) => {
extraInformation,
imagensrc,
notForSale,
onClickCardURL,
owners,
price
} = props

return (
<Card
className={'AssetCard'}
link
as={'a'}
to={`${onClickCardURL}${asset.url}`}
id={asset.id}
>
<Card className={'AssetCard'} link id={asset.id}>
{asset ? (
<>
<AssetImage
Expand Down
4 changes: 3 additions & 1 deletion src/components/AssetImage/AssetImage.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@
}

.AssetImage .image {
max-width: 100%;
margin: auto;
max-height: 100%;
z-index: 0;
}
Loading