Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keep original payload fields when (de)encoding JWT payload format #63

Merged
merged 3 commits into from
Mar 11, 2021
Merged

feat: keep original payload fields when (de)encoding JWT payload format #63

merged 3 commits into from
Mar 11, 2021

Conversation

mirceanis
Copy link
Member

closes #62

This is a breaking change since the default behavior was to delete the original fields from the transformed output.
The previous behavior can be re-enabled by setting the removeOriginalFields parameter to true when calling the transformation methods.

@mirceanis
feat: keep original payload fields when (de)encoding
550506b 
closes #62

BREAKING CHANGE: the default behavior was to delete the fields.
This can be re-enabled by setting the `removeOriginalFields` flag to `true`
@mirceanis mirceanis requested review from rado0x54 and awoie February 25, 2021 18:57
rado0x54
rado0x54 reviewed Feb 26, 2021
View reviewed changes
src/converters.ts Outdated Show resolved Hide resolved
rado0x54
rado0x54 reviewed Feb 26, 2021
View reviewed changes
src/converters.ts Outdated Show resolved Hide resolved
@rado0x54
Copy link
Contributor

Hey @mirceanis, generally ok, but I don't understand why you also implemented the functionality in the normalize* functions. I think when doing JWT->VC you never need to keep the JWT fields in that representation.

@mirceanis mirceanis requested a review from rado0x54 March 1, 2021 16:06
@mirceanis mirceanis merged commit cf59b6f into master Mar 11, 2021
@mirceanis mirceanis deleted the feat/62-payload-transformation-behavior branch March 11, 2021 14:08
uport-automation-bot pushed a commit that referenced this pull request Mar 11, 2021
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
dfd4e15 
# [1.2.0](1.1.0...1.2.0) (2021-03-11)

### Features

* add option to keep original fields when transforming JWT<->JOSE payload formats ([#63](#63)) ([cf59b6f](cf59b6f)), closes [#62](#62) [#22](#22)
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awoie awoie Awaiting requested review from awoie

@rado0x54 rado0x54 Awaiting requested review from rado0x54

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify payload transformation behavior
3 participants
@mirceanis @rado0x54 @uport-automation-bot