Standardize DID types & add did:jwk test vector #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
alecthomas,
mihai-chiorean,
mistermoe,
tomdaffurn and
wesbillman
as code owners
KendallWeihe
force-pushed
the
kendallw/web5-mixed-types
branch
from
f179412 to
5489721
Compare
KendallWeihe
changed the title
|
sorry for this lingering around @KendallWeihe ! great work |
mistermoe
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the DID part of #109 I will follow-up with the VC part.
Narrowing the scope of this PR to strictly DIDs — will do VCs in a follow up. I debated writing custom json marshalling functions to enforce existence of required properties, but instead I think it would be better to integrate with the JSON Schemas for this feature — created a ticket for this follow up work.
I’ve also added test vector support for did:jwk which tests the latest requirements as the test vectors are up to date. I considered adding did:web, but we should add bring-your-own-client feature first so that we can mock the network integration.
I also realized we're not fully conformant to our resolution error types so I opened a new ticket for that as well #132