Skip to content

Commit

Permalink
imp: improve Logger performance (cosmos#1160)
Browse files Browse the repository at this point in the history
* fix: Logger marshal errors

* changelog

* update
  • Loading branch information
fedekunze authored Apr 5, 2022
1 parent ccc4cb8 commit ffa9896
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Improvements

* (modules/core/04-channel) [\#1160](https://github.com/cosmos/ibc-go/pull/1160) Improve `uint64 -> string` performance in `Logger`.

### Features

### Bug Fixes
Expand Down
7 changes: 4 additions & 3 deletions modules/core/04-channel/keeper/packet.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package keeper

import (
"bytes"
"strconv"
"time"

sdk "github.com/cosmos/cosmos-sdk/types"
Expand Down Expand Up @@ -129,7 +130,7 @@ func (k Keeper) SendPacket(

k.Logger(ctx).Info(
"packet sent",
"sequence", packet.GetSequence(),
"sequence", strconv.FormatUint(packet.GetSequence(), 10),
"src_port", packet.GetSourcePort(),
"src_channel", packet.GetSourceChannel(),
"dst_port", packet.GetDestPort(),
Expand Down Expand Up @@ -284,7 +285,7 @@ func (k Keeper) RecvPacket(
// log that a packet has been received & executed
k.Logger(ctx).Info(
"packet received",
"sequence", packet.GetSequence(),
"sequence", strconv.FormatUint(packet.GetSequence(), 10),
"src_port", packet.GetSourcePort(),
"src_channel", packet.GetSourceChannel(),
"dst_port", packet.GetDestPort(),
Expand Down Expand Up @@ -494,7 +495,7 @@ func (k Keeper) AcknowledgePacket(
// log that a packet has been acknowledged
k.Logger(ctx).Info(
"packet acknowledged",
"sequence", packet.GetSequence(),
"sequence", strconv.FormatUint(packet.GetSequence(), 10),
"src_port", packet.GetSourcePort(),
"src_channel", packet.GetSourceChannel(),
"dst_port", packet.GetDestPort(),
Expand Down
3 changes: 2 additions & 1 deletion modules/core/04-channel/keeper/timeout.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package keeper

import (
"bytes"
"strconv"

sdk "github.com/cosmos/cosmos-sdk/types"
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
Expand Down Expand Up @@ -159,7 +160,7 @@ func (k Keeper) TimeoutExecuted(

k.Logger(ctx).Info(
"packet timed-out",
"sequence", packet.GetSequence(),
"sequence", strconv.FormatUint(packet.GetSequence(), 10),
"src_port", packet.GetSourcePort(),
"src_channel", packet.GetSourceChannel(),
"dst_port", packet.GetDestPort(),
Expand Down

0 comments on commit ffa9896

Please sign in to comment.