Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add i18n-tasks gem #114

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Add i18n-tasks gem #114

wants to merge 6 commits into from

Conversation

andreslucena
Copy link
Member

It has been reported that there are some missing translations. With a quick look, I see that we actually have several missing that I forgot about.

This PR will solve them by adding i18n-tasks gem with spec, so we don't reintroduce these kinds of problems in the future.

Copy link
Member

@NilHomedes NilHomedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check my feedback @andreslucena

config/locales/ca.yml Outdated Show resolved Hide resolved
description: S'utilitza per a la funció de fons de vídeo
service: Jitsi Meet
graphiql:docExplorerOpen:
description: Desa si teniu el tauler de documentació obert quan utilitzant
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Desa si teniu el tauler de documentació obert quan utilitzant
description: Es desa si teniu el tauler de documentació obert quan s'utilitza

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use the same formula everywhere ("S'utilitza per ..."). This is something that we aren't doing in English neither: sometimes we use "used for" other times we say "saves". I'll change all of these sentences to be consistent in all the locales.

config/locales/ca.yml Outdated Show resolved Hide resolved
config/locales/ca.yml Outdated Show resolved Hide resolved
config/locales/ca.yml Outdated Show resolved Hide resolved
items:
CONSENT:
description: >-
S'utilitza per a la funcionalitat. Té una durada de 2 anys, Google
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tinc dubtes amb l'expressió "S'utilitza per a la funcionalitat". Em sembla poc comprensible per a la gent que no domina, potser millor "S'utilitza per al correcte funcionament de nom_aplicació"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I answer you in English as this implies changes in the other languages).

I agree with what you're saying, its too technical-speak aka Klingon. This comes from the English original text ("Used for functionality"). Mind that in this case we're talking about "YouTube embeds", so the description should refer to this service.

How about this?

  • "Used for the correct functioning of the service. "
  • "Utilitzat pel corrrecte funcionament del servei"
  • "Utilitzado para el correcto funcionamiento del servicio"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Used for the correct functioning of the service. "
"Utilitzat pel corrrecte funcionament del servei"
"Utilitzado para el correcto funcionamiento del servicio"

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants