Implement Rate Limit per remote #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decke
requested changes
Apr 19, 2024
| @@ -0,0 +1,22 @@ | |||
| FROM golang:1.22-alpine AS build | |||
| @@ -10,12 +10,16 @@ require ( | |||
| ) | |||
|
|
|||
| require ( | |||
| github.com/Hepri/rate_limiter v0.0.0-20170628005159-cf154f46b333 // indirect | |||
There was a problem hiding this comment.
hm where is that dependency coming from?
| @@ -195,7 +195,7 @@ func mailHandler(peer smtpd.Peer, env smtpd.Envelope) error { | |||
| environ = append(environ, fmt.Sprintf("%s=%s", "SMTPRELAY_PEER", peerIP)) | |||
|
|
|||
| cmd := exec.Cmd{ | |||
| Env: environ, | |||
| Env: environ, | |||
| @@ -321,6 +324,13 @@ var testHookStartTLS func(*tls.Config) // nil, except for tests | |||
| // functionality. Higher-level packages exist outside of the standard | |||
| // library. | |||
| func SendMail(r *Remote, from string, to []string, msg []byte) error { | |||
| if r.RateLimiter != nil { | |||
There was a problem hiding this comment.
This is a copy from upstream Golang net/smtp and touching it should be avoided if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a rate limiter per remote configuration with an optional url parameter.
I've also added a Dockerfile to build a container image.