Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel context for mirror push command #53

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vadimartynov
Copy link
Member

Description:

We are using the push function in dhctl. This function requires the ability to be canceled via context.

Fixes:

  • Added error return from the push function for uploading a single image. Removed the use of os.Exit.
  • Implemented error groups for running the push command used for uploading a single image.
  • Changed the behavior of the retry function. Added context propagation to the function executed via retry.
  • Added context passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant