Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module): rewrite pre-delete-hook to golang #136

Merged
merged 6 commits into from
Jun 24, 2024

Conversation

fl64
Copy link
Member

@fl64 fl64 commented Jun 18, 2024

Description

Rewrite pre-delete-hook to golang

Why do we need it, and what problem does it solve?

Get rid of bash and use scratch image instead of base

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@fl64 fl64 force-pushed the refactor/module/rewrite-pre-delete-hook-to-golang branch 9 times, most recently from dc6e55e to 3d80c69 Compare June 23, 2024 15:12
images/pre-delete-hook/main.go Outdated Show resolved Hide resolved
images/pre-delete-hook/main_test.go Outdated Show resolved Hide resolved
@fl64 fl64 force-pushed the refactor/module/rewrite-pre-delete-hook-to-golang branch from 3d80c69 to 971a338 Compare June 24, 2024 15:00
@fl64 fl64 marked this pull request as ready for review June 24, 2024 15:28
@fl64 fl64 merged commit 7facaa2 into main Jun 24, 2024
10 checks passed
@fl64 fl64 deleted the refactor/module/rewrite-pre-delete-hook-to-golang branch June 24, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants