[VNDA] - Feat: add user #893
Open
+63
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging OptionsShould a new tag be published when this PR is merged?
|
gabrielMatosBoubee
requested changes
Oct 3, 2024
vnda/utils/user.ts
Outdated
Comment on lines
13
to
23
| export const setUserCookie = (headers: Headers, accessToken: string) => { | ||
| setCookie(headers, { | ||
| name: AUTH_COOKIE, | ||
| value: accessToken, | ||
| path: "/", | ||
| expires: new Date(Date.now() + ONE_WEEK_MS), | ||
| httpOnly: true, | ||
| secure: true, | ||
| sameSite: "Lax", | ||
| }); | ||
| }; |
There was a problem hiding this comment.
Não vejo isso sendo usado em nenhum lugar. Quando esse cookie vai ser salvo?
There was a problem hiding this comment.
Não vejo isso sendo usado em nenhum lugar. Quando esse cookie vai ser salvo?
Pensei em criá-lo para usar em uma futura action de signIn - para remover a necessidade do proxy para a página de login: https://developers.vnda.com.br/reference/post-api-v2-auth-client
Mas atualmente essa action não está criada e fazemos o login por proxy, então real não tem utilidade aqui no momento. Deveria remover?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this Contribution About?
This Pull Request introduces the implementation of the user hook for integrating VNDA - E-commerce Platform - with Deco.cx. This hook captures the user's
accessTokenand makes a request to the VNDA API to retrieve the associated user ID.Changes Made
Utility Function:
accessTokenfrom the user's cookie and make a call to the VNDA API to fetch the user data.Updated
useUserHook:useUserhook has been updated to incorporate the new user loading logic.Loader Implementation:
accessTokento retrieve user information.Issue Link
Please link to the relevant issue that this pull request addresses: