Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mm: Internal transfers #2891

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mm: Internal transfers #2891

wants to merge 1 commit into from

Conversation

martonp
Copy link
Contributor

@martonp martonp commented Jul 29, 2024 •
edited
Loading 

This diff updates the market maker to attempt to reallocate available funds
to bots before doing a deposit or a withdrawal. For example, if a deposit
is required, and the user has additional available funds on the CEX that are
not allocated to any bots, funds will be allocated to the bot on the CEX
and unallocated from the bot on the wallet to simulate a deposit. Bots may
be configured to only attempt these "internal transfers", to attempt both
internal and external transfers, or to do no rebalancing at all.
Screenshot 2024-11-01 at 11 22 03 AM

JoeGruffins
JoeGruffins approved these changes Aug 5, 2024
View reviewed changes
client/mm/exchange_adaptor.go Outdated Show resolved Hide resolved
client/mm/exchange_adaptor.go Outdated Show resolved Hide resolved
@martonp
Copy link
Contributor Author

martonp commented Oct 18, 2024

Can anyone reproduce the failing TestDistributions test in the CI locally? Looks like some sort of off by 1 error that consistently happens in the CI, but I cannot reproduce it.

@martonp martonp force-pushed the internalTransfers branch 3 times, most recently from 1c00913 to ff4598f Compare October 21, 2024 16:17
@martonp martonp force-pushed the internalTransfers branch 2 times, most recently from 7616c49 to 4dbe3e3 Compare November 1, 2024 10:19
@martonp
mm: Internal transfers
6c0d7cf 
This diff updates the market maker to attempt to reallocate available funds
to bots before doing a deposit or a withdrawal. For example, if a deposit
is required, and the user has additional available funds on the CEX that are
not allocated to any bots, funds will be allocated to the bot on the CEX
and unallocated from the bot on the wallet to simulate a deposit. Bots may
be configured to only attempt these "internal transfers", to attempt both
internal and external transfers, or to do no rebalancing at all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buck54321 buck54321 buck54321 left review comments

@JoeGruffins JoeGruffins JoeGruffins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martonp @buck54321 @JoeGruffins