bisonw-desktop: fix filename flavor and enforce darwin cgo minver #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukane-philemon
approved these changes
Sep 3, 2024
Comment on lines
+105
to
+106
| # Potentially want to run with CGO_CXXFLAGS="-mmacosx-version-min=10.11.0" | ||
|
|
There was a problem hiding this comment.
Can add it now I guess.
There was a problem hiding this comment.
It's not clear yet that this is necessary. Have you investigated?
There was a problem hiding this comment.
It's not necessary, just an extra constraint.
There was a problem hiding this comment.
We add it when we need it.
buck54321
added a commit
to buck54321/dcrdex
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MACOSX_DEPLOYMENT_TARGETenv var is required to compile backwards compatible cgo builds with on Mac.The
-traything was just copypasta.