get rid of dead asset zcl #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-warrior777
approved these changes
Sep 16, 2024
JoeGruffins
approved these changes
Sep 20, 2024
martonp
approved these changes
Sep 21, 2024
buck54321
force-pushed
the
nix-zclassic
branch
from
c511264
to
d6d83a8
Compare
buck54321
added a commit
to buck54321/dcrdex
that referenced
this pull request
Oct 17, 2024
* get rid of dead coin zclassic * use importall in bisonw-desktop * server too * handle missing asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also switches to using importall package in bisonw-desktop.
Does not delete the client/asset/zcl or server/asset/zcl or testing packages yet. We can do that any time, but it might be worth discussing a way to handle low-cap assets that enables them to be switched on by the user somehow, so I'll leave the code for now.
I highly doubt anybody is using bw as a Zclassic wallet, but it doesn't matter if they are, since the only option for wallet type is the external RPC wallet.