core: protect epoch checksum with its own mutex #2977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
trackedTrade.csum
field was protected under the very broadtrackedTrade.mtx
. This created lock contention when preimage requests came in for cancel orders while we had long running ticks, sinceacceptCsum
had to lock that mutex. With this change, we now protect the checksum fields for trades and cancels under a different mutex.Additionally, there were two places where the
trackedTrade.cancel
field was being read unsafely. A solution for that is implemented.Closes #2964
Supercedes #2973