Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: store unencrypted scripts in address mgr. #1500

Closed
wants to merge 2 commits into from

Conversation

dnldd
Copy link
Member

@dnldd dnldd commented Jul 9, 2019

This pr depends on #1497

This allows storing unencrypted script addresses in the address manager by modifying the address row serialization to track which entries are encrypted/raw. Storing raw scripts will become default behaviour after the wallet is upgraded.

wallet/udb/upgrades.go Outdated Show resolved Hide resolved
@dnldd dnldd changed the title multi: store unecrypted scripts in address mgr. multi: store unencrypted scripts in address mgr. Aug 6, 2019
wallet/udb/addressdb.go Outdated Show resolved Hide resolved
This allows storing unencrypted script addresses
 in the address manager. This behaviour will become
default after the wallet is upgraded.
@jrick
Copy link
Member

jrick commented Mar 5, 2020

I took a closer look at the project's history, and since the mainnet launch, dcrwallet has always stored all imported scripts both encrypted and unencrypted. So I'm thinking we can do this upgrade a lot cleaner by simply copying the unencrypted script in a db upgrade instead of changing the db schema. This will be far preferred over saving either encrypted or unencrypted scripts in the address manager buckets.

Closing this PR as it's outdated and not the most straightforward fix here.

@jrick jrick closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants