rpc: Refresh Docker for generating protobuf files. #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking to decred/dcrd#3440 as it has relevant discussion about docker image digest. |
|
Honestly, I'd prefer to see a nix flake to pin these dependencies down for our linux (and mac) developers, but these updates look reasonable. |
|
case in point why i think docker is trash: on this PR: On decred/dcrd#3440: really? |
- Pull base image by digest, helping to avoid supply chain attacks. - Use alpine base image instead of debian (245MB vs 837MB). - Update from golang 1.21.0 to 1.23.1. - Download specific version of protobuf from GitHub rather than whatever version happens to be provided by the base images package manager.
jholdstock
force-pushed
the
pb-docker
branch
from
6eb6479
to
04b2912
Compare
jrick
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR the Dockerfile did not work at all and the version of protobuf provided by Debian's package manager was v21.12. For context, the most recent pb files in the repo were built with version v27.3.