Remove legacy stakepool ticket purchasing. #2408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
force-pushed
the
rm-pool-tickets2
branch
2 times, most recently
from
2df01dc
to
dc8bab6
Compare
Preparing for some up-coming breaking changes.
It was possible to set legacy stakepool options either through config or through various RPC parameters, however the options either did nothing or enabled behaviour which is no longer valid. Breaking changes: 1. Removed PoolAddress and PoolFee parameters from gRPCs `purchasetickets` and `runticketbuyer` 1. Removed PoolAddress and PoolFee parameters from json-RPC `purchaseticket` 1. Removed config flags `--pooladdress` and `--poolfees`
jholdstock
force-pushed
the
rm-pool-tickets2
branch
from
dc8bab6
to
ce78dfc
Compare
jrick
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to set legacy stakepool options either through config or through various RPC parameters, however the options either did nothing or enabled behaviour which is no longer valid.
Breaking changes:
PoolAddressandPoolFeeparameters from gRPCspurchaseticketsandrunticketbuyerPoolAddressandPoolFeeparameters from json-RPCpurchaseticket--pooladdressand--poolfeesBased on #2411 which bumps gRPC server version to 8.0.0.