main: Update ticket buyer startup logging. #2409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all code and log messages the ticket buyer is referred to by name, however in startup/shutdown logging it was given the more vague name "auto transaction creator". Its also helpful to log whether or not the ticket buyer is purchasing mixed tickets because that has a large impact on its behaviour and potential failure modes.
|
We started leaning (or at least, I did) towards calling it the auto transaction creator since it also is responsible for mixing accounts, and it would be the place that we did hook up any other sort of automatic transaction buying in the future if we were to add more. |
|
OK I see that now, might revisit this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all code and log messages the ticket buyer is referred to by name, however in startup/shutdown logging it was given the more vague name "auto transaction creator".
Its also helpful to log whether or not the ticket buyer is purchasing mixed tickets because that has a large impact on its behaviour and potential failure modes.