Add cfg to ticketbuyer.New. #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't like this, we should keep the ability to dynamically update the config even if nothing is doing so at the moment. |
jrick
requested changes
Sep 9, 2024
jholdstock
force-pushed
the
tb-constructor
branch
from
83dd3e5
to
dfab814
Compare
Ticket buyer config is only set once at creation and then not accessed again from externally, so there is no need for an AccessConfig func, it can just be passed into New.
jrick
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket buyer config is only set once at creation and then not accessed again from externally, so there is no need for an AccessConfig func, it can just be passed into New.