Move VSP client code to wallet package #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a proof of concept on dcrdex to demonstrate that the package reshuffle has minimal impact on existing users. The only notable changes are in spv.go |
|
No objections, with the tor change I can see the benefit of moving this to the wallet package. |
|
(please squash manually so the commit message is clean) |
This moves the VSP client code from its own package into the wallet package. Moving this code should have minimal impact on consumers of the vsp package because they will have been importing the wallet package already due to the fact that a VSP client could not be created without an instance of wallet. The benefits of this are: - vsp client creation now exists only in the wallet package, rather than being scattered across 3 packages. - vsp client loading funcs and variables are no longer package global. - simplifies the creation of a vsp client because the wallet no longer needs to be passed into the func as a param. - no longer necessary to abstract the vsp client away by referring to its methods, the client can just be used directly.
jholdstock
force-pushed
the
wallet-vsp
branch
from
e0384fa
to
d7f30a9
Compare
jrick
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving this code should have minimal impact on consumers of the vsp package because they will have been importing the wallet package already due to the fact that a VSP client could not be created without an instance of wallet.
The benefits of this are:
Can be squashed before merging.