-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of FILTER parameters with INTERSECTS #118
Merged
copierrj
merged 11 commits into
deegree:main
from
lat-lon:feature/filterWithIntersects-9567
Jul 17, 2024
Merged
Support of FILTER parameters with INTERSECTS #118
copierrj
merged 11 commits into
deegree:main
from
lat-lon:feature/filterWithIntersects-9567
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, implemented Cql2FilterVisitor and Cql2ParserTest
# Conflicts: # pom.xml
tfr42
reviewed
May 8, 2024
deegree-ogcapi-features/src/main/antlr4/org/deegree/services/oaf/cql2/Cql2.g4
Show resolved
Hide resolved
stephanr
requested changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The license header is missing for the new Java files in the package org.deegree.services.oaf.cql2
.
Also, it is not clear to me if the added grammar file cql2.g4
is also required to have a license header.
dstenger
approved these changes
Jul 17, 2024
stephanr
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements parts of OGC API - Features - Part 3. The implementation is not fully supporting the following requirements classes: "Queryables", "Queryables as Query Parameters", "Filter" with "CQL2 Functions", and "Features Filter".
Implementation is limited to S_INTERSECTS({spatialQueryable},{spatialInstance})