Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization of vendor-specific rendering of a graphic on a line #1423

Merged

Conversation

stephanr
Copy link
Member

@stephanr stephanr commented Nov 11, 2022

This PR implements the changed described/discussed in #1418 an is a small part of #1204 (replaces AnchoredSymbol)
Includes #1405 as it requires its fixes to the SVG for tests
Extends the unit test introduced with #1420

The following changed to GraphicStroke are made:

  • rotation to align with line segment can be controlled with deegree-graphicstroke-rotation
  • position on line is configured by deegree-graphicstroke-position-percentage
  • PositionPercentage will still be parsered but creates a warning in the logfile
  • AnchorPoint and Displacement can now be used for SVG and Mark and images
  • images can now be drawn along lines as well
  • svg can either be drawn like images (Graphic/ExternalGraphic/OnlineResource) or like Mark (Graphic/Mark/OnlineResource)
    • this can be reverted with the option deegree.rendering.graphicstroke.svg-as-mark
    • included in documentation

Closes #1418

…into enhancement/graphic-stroke-with-point-199-1204
…' and 'deegree-graphicstroke-rotation'

add deprecation warning for the Element 'PositionPercentage'
@stephanr stephanr added enhancement enhancement or improvement WMS deegree Web Map Service labels Nov 11, 2022
@stephanr stephanr added this to the 3.5 milestone Nov 11, 2022
@stephanr stephanr changed the title Optimization of vendor-specific rendering of a symbol on a line Optimization of vendor-specific rendering of a graphic on a line Nov 16, 2022
@copierrj copierrj merged commit ac2832b into deegree:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement or improvement WMS deegree Web Map Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimization of vendor-specific rendering of a symbol on a line
2 participants