Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for TLS redis connection #2308

Merged
merged 1 commit into from
Sep 17, 2024
Merged

add support for TLS redis connection #2308

merged 1 commit into from
Sep 17, 2024

Conversation

finchr
Copy link
Contributor

@finchr finchr commented Sep 16, 2024

Fixes #

Changes proposed in this pull request:

  • add support for TLS redis connections to support AWS ElastiCache

gnmahanth
gnmahanth approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@gnmahanth gnmahanth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finchr Thanks for the PR

@ramanan-ravi please cherry-pick to main branch

@ramanan-ravi ramanan-ravi merged commit f4ee9f3 into deepfence:release-2.3 Sep 17, 2024
3 checks passed
ramanan-ravi added a commit that referenced this pull request Sep 17, 2024
@ramanan-ravi
Revert "add support for TLS redis connection (#2308)"
3594d43 
This reverts commit f4ee9f3.
@ramanan-ravi ramanan-ravi mentioned this pull request Sep 17, 2024
Merged
ramanan-ravi added a commit that referenced this pull request Sep 17, 2024
@ramanan-ravi
Revert "add support for TLS redis connection" (#2309)
c0df1c2 
Revert "add support for TLS redis connection (#2308)"

This reverts commit f4ee9f3.
@gnmahanth
Copy link
Contributor

gnmahanth commented Sep 17, 2024 •
edited
Loading

@finchr what is the expected value for DEEPFENCE_REDIS_TLS ? can you provide some example and add the emaple in docker compose before we merge this ?

is it like DEEPFENCE_REDIS_TLS=true or DEEPFENCE_REDIS_TLS=1 will enable tls config ?

@ramanan-ravi ramanan-ravi mentioned this pull request Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnmahanth gnmahanth gnmahanth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@finchr @gnmahanth @ramanan-ravi