-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ListView actions #1968
feat: ListView actions #1968
Conversation
5593bd0
to
709d10d
Compare
dfca0c3
to
a69bd62
Compare
@@ -28,21 +28,21 @@ | |||
} | |||
|
|||
.dh-list-view-wrapper-density-compact { | |||
svg[class*='react-spectrum-ListViewItem-thumbnail'] { | |||
svg[class*='spectrum-Icon'] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This includes action group icons so they don't cause item height to change
641842e
to
2086850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the ticking table example, it's adding/removing event listeners each time, and there seems to be some lag (using the lv_table = examples(column_types_ticking)
line that's commented out in your example in the PR description). Even with a simple case where it's just a ticking table:
from deephaven import time_table, ui
tt = time_table("PT1s").update("X=i")
my_list_view = ui.list_view(tt)
It seems to be adding the listen again with each tick, which we shouldn't need to do. Should only need to add it once; something isn't being memoized correctly there.
Unsure if caused by this change or not, but please take a look at that before this merges.
2086850
to
4af32c5
Compare
Table subscriptions happen inside of I've created #2003 to address the underlying issue. |
4af32c5
to
5ec88af
Compare
@mofojed the PR that fixed the subscriptions has been merged, and this PR is rebase on it, so should see that problem go away now. |
ActionGroup
andActionMenu
to support primitive itemsListActionGroup
andListActionMenu
components to support providing actions prop toListView
ListView
actions
prop supportThe branch in this PR can be used to see this in action. I also published an alpha this branch (0.77.1-alpha-listview-actions.4) to make types work in plugins
Example of standalone
ui.action_group
andui.action_menu
Example showing actions in
ui.list_view
with different densities