-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: SampleSection component to conditionally render based on route #2000
refactor: SampleSection component to conditionally render based on route #2000
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2000 +/- ##
==========================================
+ Coverage 46.35% 46.37% +0.02%
==========================================
Files 670 669 -1
Lines 38735 38713 -22
Branches 9806 9807 +1
==========================================
Hits 17955 17955
+ Misses 20727 20705 -22
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6d064af
to
335559a
Compare
SampleSection component is now responsible for rendering / not rendering based on route. Contrast to before where we rendered everything and then hid via css.
Seems to cut time to run styleguide tests by more than half locally.