Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] Change loging level to debug #3336

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

xyang16
Copy link
Contributor

@xyang16 xyang16 commented Jul 12, 2024

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@@ -167,7 +167,7 @@ private static boolean copyJniLibraryFromClasspath(
Utils.moveQuietly(tmp, dir);
return true;
} catch (IOException e) {
logger.error("Cannot copy jni files", e);
logger.debug("Cannot copy jni files: {}", e.getMessage());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We should check null for cu122 case at line 162, it will throw and NPE.
  2. We should keep it as warning at least. IOException should not happen.

Copy link
Contributor Author

@xyang16 xyang16 Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For cu122, it will not throw NPE. It will throw IOException:

Resource not found in classpath: native/lib/linux-x86_64/cu122/libtokenizers.so

So IOException is expected to happen, then it will proceed to download.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.89%. Comparing base (90680b3) to head (0e4b407).
Report is 6 commits behind head on master.

Files Patch % Lines
...va/ai/djl/huggingface/tokenizers/jni/LibUtils.java 0.00% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3336      +/-   ##
============================================
- Coverage     72.93%   72.89%   -0.05%     
  Complexity     7328     7328              
============================================
  Files           668      668              
  Lines         32415    32443      +28     
  Branches       3418     3428      +10     
============================================
+ Hits          23642    23648       +6     
- Misses         7165     7182      +17     
- Partials       1608     1613       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xyang16 xyang16 merged commit 4b4d605 into deepjavalibrary:master Jul 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants