Fix Float default values (#13)

deepmedia · Sep 3, 2024 · 244de51 · 244de51
1 parent f20d9e0
commit 244de51
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 3 deletions.
diff --git a/knee-compiler-plugin/build.gradle.kts b/knee-compiler-plugin/build.gradle.kts
@@ -7,7 +7,7 @@ plugins {
 
 dependencies {
     compileOnly("org.jetbrains.kotlin:kotlin-compiler-embeddable")
-    implementation("com.squareup:kotlinpoet:1.12.0")
+    implementation("com.squareup:kotlinpoet:1.18.1")
     implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3")
 }
 

diff --git a/knee-compiler-plugin/src/main/kotlin/utils/PoetUtils.kt b/knee-compiler-plugin/src/main/kotlin/utils/PoetUtils.kt
@@ -208,12 +208,12 @@ fun IrValueParameter.defaultValueForCodegen(functionExpects: List<IrDeclarationW
         return when (val kind = expression.kind) {
             is IrConstKind.Null -> CodeBlock.of("null")
             is IrConstKind.String -> CodeBlock.of("%S", kind.valueOf(expression))
+            is IrConstKind.Float -> CodeBlock.of("%LF", kind.valueOf(expression))
+            is IrConstKind.Long -> CodeBlock.of("%LL", kind.valueOf(expression))
             else -> CodeBlock.of("%L", kind.valueOf(expression))
             // is IrConstKind.Boolean -> CodeBlock.of(kind.valueOf(expression).toString())
             // is IrConstKind.Int -> CodeBlock.of(kind.valueOf(expression).toString())
             // is IrConstKind.Double -> CodeBlock.of(kind.valueOf(expression).toString())
-            // is IrConstKind.Float -> CodeBlock.of(kind.valueOf(expression).toString() + "F")
-            // is IrConstKind.Long -> CodeBlock.of(kind.valueOf(expression).toString() + "L")
             // else -> return null
         }
     } else if (expression is IrGetEnumValue && type is IrSimpleType) {

diff --git a/...sc/src/androidInstrumentedTest/kotlin/io/deepmedia/tools/knee/tests/DefaultValuesTests.kt b/...sc/src/androidInstrumentedTest/kotlin/io/deepmedia/tools/knee/tests/DefaultValuesTests.kt
@@ -31,4 +31,14 @@ class DefaultValuesTests {
         enumDefaultValue()
     }
 
+    @Test
+    fun testDefaultValue_float() {
+        floatDefaultValue()
+    }
+
+    @Test
+    fun testDefaultValue_long() {
+        floatDefaultValue()
+    }
+
 }
diff --git a/tests/test-misc/src/backendMain/kotlin/DefaultValuesDefinitions.kt b/tests/test-misc/src/backendMain/kotlin/DefaultValuesDefinitions.kt
@@ -24,6 +24,14 @@ interface BaseInterfaceWithDefaultValues {
 fun emptyStringDefaultValue(foo: String = "") {
 }
 
+@Knee
+fun floatDefaultValue(foo: Float = 1F) {
+}
+
+@Knee
+fun longDefaultValue(foo: Long = 1000L) {
+}
+
 @Knee
 fun enumDefaultValue(foo: DefaultValuesEnum = DefaultValuesEnum.First) {
 }