cc: refactor DataModifier for multiple-backend framework #3148
Conversation
Signed-off-by: Jinzhe Zeng <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel #3148 +/- ##
==========================================
- Coverage 76.26% 76.23% -0.03%
==========================================
Files 272 274 +2
Lines 25537 25570 +33
Branches 1583 1587 +4
==========================================
+ Hits 19475 19494 +19
- Misses 5135 5147 +12
- Partials 927 929 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jinzhe Zeng <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| assert(output_f.dims() == 2 && "dim of output tensor should be 2"); | ||
| assert(output_v.dims() == 2 && "dim of output tensor should be 2"); | ||
| assert(output_av.dims() == 2 && "dim of output tensor should be 2"); | ||
| int nframes = output_f.dim_size(0); |
Check notice
Code scanning / CodeQL
Unused local variable Note
| assert(output_v.dims() == 2 && "dim of output tensor should be 2"); | ||
| assert(output_av.dims() == 2 && "dim of output tensor should be 2"); | ||
| int nframes = output_f.dim_size(0); | ||
| int natoms = output_f.dim_size(1) / 3; |
Check notice
Code scanning / CodeQL
Unused local variable Note
| const InputNlist& lmp_list) { | ||
| // firstly do selection | ||
| int nall = datype_.size(); | ||
| int nloc = nall - nghost; |
Check notice
Code scanning / CodeQL
Unused local variable Note
| // sort atoms | ||
| AtomMap atommap(datype_real.begin(), datype_real.begin() + nloc_real); | ||
| assert(nloc_real == atommap.get_type().size()); | ||
| const std::vector<int>& sort_fwd_map(atommap.get_fwd_map()); |
Check notice
Code scanning / CodeQL
Unused local variable Note
wanghan-iapcm
requested review from
CaRoLZhangxy
and removed request for
CaRoLZhangxy
Signed-off-by: Jinzhe Zeng <[email protected]>
for more information, see https://pre-commit.ci
See #3119