Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd: fix learning rate setting when resume #4480

Merged
merged 2 commits into from
Dec 20, 2024
Merged

pd: fix learning rate setting when resume #4480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79d3169
Correct resume lr_scheduler step
HydrogenSulfate Dec 20, 2024
5fb1509
refine
HydrogenSulfate Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions deepmd/pd/train/training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,15 +588,14 @@
if self.opt_type == "Adam":
self.scheduler = paddle.optimizer.lr.LambdaDecay(
learning_rate=self.lr_exp.start_lr,
lr_lambda=lambda step: warm_up_linear(
step + self.start_step, self.warmup_steps
),
lr_lambda=lambda step: warm_up_linear(step, self.warmup_steps),
)
self.optimizer = paddle.optimizer.Adam(
learning_rate=self.scheduler, parameters=self.wrapper.parameters()
)
if optimizer_state_dict is not None and self.restart_training:
self.optimizer.set_state_dict(optimizer_state_dict)
self.scheduler.last_epoch -= 1

Check warning on line 598 in deepmd/pd/train/training.py

View check run for this annotation

Codecov / codecov/patch

deepmd/pd/train/training.py#L598 

Added line #L598 was not covered by tests
else:
raise ValueError(f"Not supported optimizer type '{self.opt_type}'")

Expand Down
Loading