Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: continue_on_success_ratio without slice raise error #852

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saltball
Copy link

@saltball saltball commented Sep 2, 2024

For some conditions, the slice expression do not worked for if_expression when combining and split the job groups. This PR tries to fix this.
The problem hardly effect the normal users especially the executor users. I'll check it further and provide details later.

@zjgemi
Copy link
Collaborator

zjgemi commented Sep 3, 2024

Can you provide an example?
It is known that for some certain Argo versions, the if_expression for group_size will cause error. I'm not sure if the issue is related to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants