Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discriminate frames with virials labels in Multisystem class #294

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

PKUfjh
Copy link
Contributor

@PKUfjh PKUfjh commented May 24, 2022

Sometimes we came across with multisystem (such as quip/gap/xyz format files) which has both frames with virials labels and frames without virials labels. The current implementation of the Multisystems class will lead to error message:

RuntimeError: system has virial, but this does not

But this kind of Multisystems are in fact trainable, so I identify frames with virials in Multisystems, such that Systems will have names as:

C60  C60_virials

The former represents systems with 60 carbon atoms without virials labels, the latter represents systems with 60 carbon atoms with virials labels.

@PKUfjh PKUfjh changed the title discriminate virials labels in Multisystem class discriminate frames with virials labels in Multisystem class May 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #294 (31438f0) into devel (c0bb798) will decrease coverage by 0.03%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##            devel     #294      +/-   ##
==========================================
- Coverage   81.57%   81.53%   -0.04%     
==========================================
  Files          62       62              
  Lines        5244     5249       +5     
==========================================
+ Hits         4278     4280       +2     
- Misses        966      969       +3     
Impacted Files Coverage Δ
dpdata/plugins/ase.py 64.51% <0.00%> (-3.29%) ⬇️
dpdata/system.py 85.28% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0bb798...31438f0. Read the comment docs.

Copy link
Contributor

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change to the code that has potential influence on other codes using dpdata.MultiSystems with explicit formula.

I do not support the merging of this PR.

@PKUfjh
Copy link
Contributor Author

PKUfjh commented May 25, 2022

This is a breaking change to the code that has potential influence on other codes using dpdata.MultiSystems with explicit formula.

I do not support the merging of this PR.

Actually this change just modifies the system names in the MultiSystems frames (add "_virials" to the system names), I do not see what negative influence this change will have on other codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants