Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fromage annotator and dff-fromage-image-skill #523
Fromage annotator and dff-fromage-image-skill #523
Changes from 39 commits
d0b08f5
0cb87b2
bab2637
47ce513
91eea80
bba720f
cfd369a
f0355ea
b1733e6
7076464
fd1aa4a
fee6619
9336741
664247a
ea72150
dd03722
63bf07d
51f5849
9561e7b
b3e439f
bbeef22
3a530f6
45736fa
1c1a751
388b4a8
c57f79c
acca372
68366e4
a2c1b99
ea8d7ed
6e48893
fe81b4d
48d1a98
9ca4fe9
5209885
0113ad5
b03b6b7
79e4613
3c6bba9
d8250f4
82f2753
f7701ad
dfe7429
6e4354a
d957334
9bb2820
45ac064
dada95e
c17424b
a3b25be
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
а добавить вместо него ranking-based?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
почему используется description based skill selector, а добавляется он в rule based selector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
так вроде щас description based skill selector как в деве дрима основного, или нет? я запуталась
вернуть rule_based? я вроде везде его выпилила и по поиску в папке вроде ничего на него не похоже
или он не туда встал?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
я к тому, что у тебя должен использоваться тот же скилл селектор, в код которого ты добавила скилл)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
да,в ерни rule based skill selector