Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Reject Incompatible models #1056

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

raspawar
Copy link
Contributor

@raspawar raspawar commented Sep 6, 2024

As a user of the connectors, I can select from many modals and want to be alerted early if a model is not compatible with my use case.

Example test, w/ public_class of NvidiaGenerator, NvidiaTextEmbedder, NvidiaDocumentEmbedder for HayStack -

invalid = select known model that does not work with public_class, e.g. NV-Embed-QA and NvidiaGenerator
public_class(model=invalid, nvidia_api_key="a-bogus-key")

cc: @sumitkbh @mattf

@github-actions github-actions bot added type:documentation Improvements or additions to documentation integration:nvidia labels Sep 6, 2024
@raspawar raspawar marked this pull request as ready for review September 23, 2024 08:11
@raspawar raspawar requested a review from a team as a code owner September 23, 2024 08:11
@raspawar raspawar requested review from shadeMe and removed request for a team September 23, 2024 08:11
@raspawar
Copy link
Contributor Author

@mattf ptal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:nvidia type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant