-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: adopt uv as installer #1142
Conversation
detached = true | ||
dependencies = ["black>=23.1.0", "mypy>=1.0.0", "ruff>=0.0.243"] | ||
dependencies = ["pip", "black>=23.1.0", "mypy>=1.0.0", "ruff>=0.0.243"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip
is needed by mypy
to install missing stub packages
@@ -30,6 +30,7 @@ dependencies = [ | |||
# Commenting some of them to not interfere with the dependencies of Haystack. | |||
#"transformers==4.20.0", | |||
"datasets>=2.2.0", | |||
"huggingface_hub<0.26.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated. https://github.com/xlang-ai/instructor-embedding is practically abandoned and the release of huggingface_hub
broke it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing cause of unrelated changes, will merge in any case.
Related Issues
Proposed Changes:
How did you test it?
CI
Notes for the reviewer
Some failing tests:
test_multiple_contains
is failing #1133Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.