Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: adopt uv as installer #1142

Merged
merged 12 commits into from
Oct 18, 2024
Merged

ci: adopt uv as installer #1142

merged 12 commits into from
Oct 18, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Oct 17, 2024 •
edited
Loading

Related Issues

Proposed Changes:

  • adopt uv as installer

How did you test it?

CI

Notes for the reviewer

Some failing tests:

Checklist

anakin87
anakin87 commented Oct 17, 2024
View reviewed changes
integrations/amazon_bedrock/pyproject.toml
detached = true
dependencies = ["black>=23.1.0", "mypy>=1.0.0", "ruff>=0.0.243"]
dependencies = ["pip", "black>=23.1.0", "mypy>=1.0.0", "ruff>=0.0.243"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pip is needed by mypy to install missing stub packages

@anakin87 anakin87 marked this pull request as ready for review October 17, 2024 10:22
@anakin87 anakin87 requested a review from a team as a code owner October 17, 2024 10:22
@anakin87 anakin87 requested review from shadeMe and silvanocerza and removed request for a team October 17, 2024 10:22
@anakin87 anakin87 changed the title try uv ci: adopt uv as installer Oct 17, 2024
@anakin87 anakin87 mentioned this pull request Oct 18, 2024
Merged
@anakin87 anakin87 marked this pull request as draft October 18, 2024 08:50
@shadeMe shadeMe removed their request for review October 18, 2024 09:20
anakin87
anakin87 commented Oct 18, 2024
View reviewed changes
integrations/instructor_embedders/pyproject.toml
@@ -30,6 +30,7 @@ dependencies = [
# Commenting some of them to not interfere with the dependencies of Haystack.
#"transformers==4.20.0",
"datasets>=2.2.0",
"huggingface_hub<0.26.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated. https://github.com/xlang-ai/instructor-embedding is practically abandoned and the release of huggingface_hub broke it.

@anakin87 anakin87 marked this pull request as ready for review October 18, 2024 09:48
silvanocerza
silvanocerza approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing cause of unrelated changes, will merge in any case.

@anakin87 anakin87 merged commit f166d91 into main Oct 18, 2024
139 of 158 checks passed
@anakin87 anakin87 deleted the adopt-uv branch October 18, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvanocerza silvanocerza silvanocerza approved these changes

Assignees
No one assigned
Labels
integration:amazon-bedrock integration:amazon-sagemaker integration:astra integration:chroma integration:cohere integration:deepeval integration:elasticsearch integration:fastembed integration:google-ai integration:google-vertex integration:instructor-embedders integration:jina integration:langfuse integration:llama_cpp integration:mistral integration:mongodb-atlas integration:nvidia integration:ollama integration:opensearch integration:optimum integration:pgvector integration:pinecone integration:qdrant integration:ragas integration:snowflake integration:unstructured-fileconverter integration:weaviate topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @silvanocerza