Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove dependency constraints for instructor-embedders #1155

Closed
wants to merge 1 commit into from
Closed

fix: remove dependency constraints for instructor-embedders #1155

wants to merge 1 commit into from

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented Oct 25, 2024 •
edited
Loading

Related Issues

  • fixes dependency constraints for instructor-embedders being too restrictive. They have been taken from the repo as the package itself doesn't have proper dependencies. Even in the repo they made them less restrictive

Proposed Changes:

  • remove version constraint for sentence-transformers and huggingface-hub

How did you test it?

Notes for the reviewer

Checklist

@tstadel tstadel requested a review from a team as a code owner October 25, 2024 10:04
@tstadel tstadel requested review from shadeMe and removed request for a team October 25, 2024 10:04
@tstadel tstadel closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadeMe shadeMe Awaiting requested review from shadeMe shadeMe is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
integration:instructor-embedders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tstadel