Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing docstrings in document store base tests #7509

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented Apr 9, 2024

Related Issues

Proposed Changes:

Ignore docstrings presence for legacy tests

How did you test it?

Notes for the reviewer

Checklist

@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Apr 9, 2024
@masci masci requested a review from a team as a code owner April 9, 2024 06:38
@masci masci requested review from julian-risch and removed request for a team April 9, 2024 06:38
@github-actions github-actions bot added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs labels Apr 9, 2024
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
pylint still complains about empty-docstring.

@coveralls
Copy link
Collaborator

coveralls commented Apr 9, 2024

Pull Request Test Coverage Report for Build 8611504773

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.842%

Totals Coverage Status
Change from base Build 8603659000: 0.0%
Covered Lines: 6023
Relevant Lines: 6704

💛 - Coveralls

@masci masci merged commit 174ac79 into main Apr 9, 2024
20 checks passed
@masci masci deleted the massi/testing-ds-docstrings branch April 9, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants