-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add default_headers for azure embeddings #8535
base: main
Are you sure you want to change the base?
feat: add default_headers for azure embeddings #8535
Conversation
Benjamin Nuernberger seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Pull Request Test Coverage Report for Build 11790285279Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@nuernber thanks for the contribution. Can you please sign the CLA? |
@@ -95,6 +96,7 @@ def __init__( # noqa: PLR0913 (too-many-arguments) | |||
`OPENAI_TIMEOUT` environment variable, or 30 seconds. | |||
:param max_retries: Maximum number of retries to contact AzureOpenAI after an internal error. | |||
If not set, defaults to either the `OPENAI_MAX_RETRIES` environment variable or to 5 retries. | |||
:param default_headers: Default headers to use for the AzureOpenAI client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:param default_headers: Default headers to use for the AzureOpenAI client. | |
:param default_headers: Default headers to send to the AzureOpenAI client. |
@@ -82,6 +83,7 @@ def __init__( | |||
A string to add at the beginning of each text. | |||
:param suffix: | |||
A string to add at the end of each text. | |||
:param default_headers: Default headers to use for the AzureOpenAI client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:param default_headers: Default headers to use for the AzureOpenAI client. | |
:param default_headers: Default headers to send to the AzureOpenAI client. |
@nuernber left a few comments - one question still, is the |
@davidsbatista |
Related Issues
Proposed Changes:
Follows the logic from
AzureOpenAIGenerator
fordefault_headers
:haystack/haystack/components/generators/azure.py
Line 71 in 852900d
and
haystack/haystack/components/generators/azure.py
Line 152 in 852900d
How did you test it?
Ran the unit tests and also tested with my Azure set up that uses a subscription key.
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.