Skip to content

Commit

Permalink
More header cleaning up done.
Browse files Browse the repository at this point in the history
Removal of fixed includes as they are in stdafx.h
Fixed a few files not using pch's
  • Loading branch information
SimonCSmith committed Mar 7, 2023
1 parent ca48c0b commit 3c67cd0
Show file tree
Hide file tree
Showing 48 changed files with 60 additions and 174 deletions.
2 changes: 0 additions & 2 deletions ChartCtrl/ChartLegend.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@

#include "ChartObject.h"

#include <string>

class CChartSerie;

class CChartLegend : public CChartObject
Expand Down
1 change: 0 additions & 1 deletion ChartCtrl/ChartTitle.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

#include "stdafx.h"
#include "ChartTitle.h"
#include "Math.h"

using namespace std;

Expand Down
4 changes: 0 additions & 4 deletions ChartCtrl/ChartTitle.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@

#include "ChartObject.h"

#include <vector>
#include <string>


class CChartTitle : public CChartObject
{
friend CChartCtrl;
Expand Down
2 changes: 0 additions & 2 deletions DeepSkyStacker/AHDDemosaicing.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
#include <stdafx.h>
#include <vector>
#include <omp.h>
#include "AHDDemosaicing.h"
#include "ColorBitmap.h"
#include "Ztrace.h"
Expand Down
2 changes: 0 additions & 2 deletions DeepSkyStacker/About.h
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
#ifndef ABOUT_H
#define ABOUT_H

#include <QDialog>

namespace Ui {
class About;
}
Expand Down
1 change: 0 additions & 1 deletion DeepSkyStacker/BackgroundCalibration.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include <stdafx.h>
#include <omp.h>
#include "resource.h"
#include "BitmapBase.h"
#include "BackgroundCalibration.h"
Expand Down
14 changes: 1 addition & 13 deletions DeepSkyStacker/BackgroundOptions.cpp
Original file line number Diff line number Diff line change
@@ -1,19 +1,7 @@
#include "stdafx.h"
#include <algorithm>
using std::min;
using std::max;

#define _WIN32_WINNT _WIN32_WINNT_WIN7
#include <afx.h>

#include "BackgroundOptions.h"
#include "ui/ui_BackgroundOptions.h"

#include <ZExcept.h>
#include <Ztrace.h>

#include "DSSCommon.h"
#include "StackingTasks.h"
#include "../DeepSkyStackerTest/AvxAccumulateTest.h"
#include "Workspace.h"


Expand Down
2 changes: 0 additions & 2 deletions DeepSkyStacker/BackgroundOptions.h
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
#ifndef BACKGROUNDOPTIONS_H
#define BACKGROUNDOPTIONS_H

#include <QDialog>

enum BACKGROUNDCALIBRATIONMODE : short;
enum BACKGROUNDCALIBRATIONINTERPOLATION : short;
enum RGBBACKGROUNDCALIBRATIONMETHOD : short;
Expand Down
3 changes: 0 additions & 3 deletions DeepSkyStacker/BaseDialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,6 @@
// BaseDialog.cpp : implementation file
//
#include "stdafx.h"
#include <QShowEvent>
#include <QSettings>

#include "DeepSkyStacker.h"
#include "BaseDialog.h"

Expand Down
2 changes: 0 additions & 2 deletions DeepSkyStacker/BaseDialog.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
#pragma once
#include <QDialog>
#include <QFlags>

namespace DSS
{
Expand Down
2 changes: 0 additions & 2 deletions DeepSkyStacker/BilinearParameters.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#pragma once

#include <atlstr.h>

typedef enum TRANSFORMATIONTYPE
{
TT_LINEAR = 0,
Expand Down
8 changes: 0 additions & 8 deletions DeepSkyStacker/BitmapExt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -835,14 +835,6 @@ bool ApplyGammaTransformation(C32BitsBitmap* pOutBitmap, CMemoryBitmap* pInBitma
/* ------------------------------------------------------------------- */
/* ------------------------------------------------------------------- */

#pragma warning( push )
#pragma warning( disable: 4996 ) // Remove this as soon as having switched to c++20.

#include <concurrent_unordered_set.h>
#include <shared_mutex>

#pragma warning( pop )

namespace {
//
// Fowler/Noll/Vo hash
Expand Down
7 changes: 0 additions & 7 deletions DeepSkyStacker/BitmapInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,6 @@
#include "BitmapInfo.h"
#include "Ztrace.h"


// Don't want these really.
#include <atlcomcli.h>
#include <atlstr.h>
#include <GdiPlus.h>
using namespace Gdiplus;

bool RetrieveEXIFInfo(LPCTSTR szFileName, CBitmapInfo& BitmapInfo)
{
ZFUNCTRACE_RUNTIME();
Expand Down
1 change: 0 additions & 1 deletion DeepSkyStacker/CometStacking.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
class QPixmap;

#include "DSSCommon.h"
#include <QWidget>

namespace Ui {
class CometStacking;
Expand Down
1 change: 0 additions & 1 deletion DeepSkyStacker/CosmeticEngine.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include <stdafx.h>
#include <omp.h>
#include "CosmeticEngine.h"
#include "MemoryBitmap.h"
#include "Ztrace.h"
Expand Down
1 change: 0 additions & 1 deletion DeepSkyStacker/DarkFrame.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include <stdafx.h>
#include <omp.h>
#include "DarkFrame.h"
#include "Ztrace.h"
#include "DSSProgress.h"
Expand Down
1 change: 0 additions & 1 deletion DeepSkyStacker/DeepSkyStacker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
// DeepSkyStacker.cpp : Defines the entry point for the console application.
//
#include <stdafx.h>
#include <atlstr.h>

#include "DeepSkyStacker.h"

Expand Down
22 changes: 10 additions & 12 deletions DeepSkyStacker/DeepSkyStacker.vcxproj
Original file line number Diff line number Diff line change
Expand Up @@ -305,13 +305,13 @@ $(QtToolsPath)\windeployqt --pdb $(TargetPath)</Command>
<ClCompile Include="GrayBitmap.cpp" />
<ClCompile Include="GreyMultiBitmap.cpp" />
<ClCompile Include="group.cpp">
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">NotUsing</PrecompiledHeader>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|x64'">NotUsing</PrecompiledHeader>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">Use</PrecompiledHeader>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|x64'">Use</PrecompiledHeader>
</ClCompile>
<ClCompile Include="ImageSinks.cpp" />
<ClCompile Include="imageview.cpp">
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">NotUsing</PrecompiledHeader>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|x64'">NotUsing</PrecompiledHeader>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">Use</PrecompiledHeader>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|x64'">Use</PrecompiledHeader>
</ClCompile>
<ClCompile Include="MemoryBitmap.cpp" />
<ClCompile Include="picturelist.cpp" />
Expand All @@ -337,12 +337,10 @@ $(QtToolsPath)\windeployqt --pdb $(TargetPath)</Command>
<ClCompile Include="FrameInfo.cpp" />
<ClCompile Include="FrameList.cpp" />
<ClCompile Include="ImageListModel.cpp">
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">NotUsing</PrecompiledHeader>
<PrecompiledHeaderFile Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
</PrecompiledHeaderFile>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|x64'">NotUsing</PrecompiledHeader>
<PrecompiledHeaderFile Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
</PrecompiledHeaderFile>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">Use</PrecompiledHeader>
<PrecompiledHeaderFile Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">stdafx.h</PrecompiledHeaderFile>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|x64'">Use</PrecompiledHeader>
<PrecompiledHeaderFile Condition="'$(Configuration)|$(Platform)'=='Release|x64'">stdafx.h</PrecompiledHeaderFile>
</ClCompile>
<ClCompile Include="imageloader.cpp">
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">Use</PrecompiledHeader>
Expand Down Expand Up @@ -375,8 +373,8 @@ $(QtToolsPath)\windeployqt --pdb $(TargetPath)</Command>
<ClCompile Include="ProcessingDlg.cpp" />
<ClCompile Include="ProcessSettingsSheet.cpp" />
<ClCompile Include="QLinearGradientCtrl.cpp">
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">NotUsing</PrecompiledHeader>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|x64'">NotUsing</PrecompiledHeader>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">Use</PrecompiledHeader>
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|x64'">Use</PrecompiledHeader>
</ClCompile>
<ClCompile Include="qwinhost.cpp">
<PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">NotUsing</PrecompiledHeader>
Expand Down
12 changes: 0 additions & 12 deletions DeepSkyStacker/DeepStackerDlg.cpp
Original file line number Diff line number Diff line change
@@ -1,24 +1,12 @@
// DeepStackerDlg.cpp : implementation file
//

#include "stdafx.h"
#include "DeepSkyStacker.h"
#include "DeepStackerDlg.h"
#include "DSS-versionhelpers.h"
#include <QtWidgets/QApplication>
#include <QtWidgets/QHBoxLayout>
#include <QtWidgets/QSplitter>
#include <QtWidgets/QStackedWidget>
#include <QtWidgets/QWidget>
#include <QRect>
#include <QScreen>
#include <QSettings>

#include "ExplorerBar.h"
#include "StackingDlg.h"



/* ------------------------------------------------------------------- */

static bool GetDefaultSettingsFileName(CString & strFile)
Expand Down
4 changes: 0 additions & 4 deletions DeepSkyStacker/DeepStackerDlg.h
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@


#pragma once

// DeepStackerDlg.h : header file
//

#include "DeepStack.h"
#include "DeepSkyStacker.h"
#include <list>

class CDSSSetting
{
Expand Down
6 changes: 1 addition & 5 deletions DeepSkyStacker/Delaunay.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,7 @@
// mailto:[email protected]

#pragma once

#include <set>
#include <algorithm>
#include <math.h>
#include "ZExcept.h"
#include "ZExcBase.h"

//
// changes to remove dependencies on Microsoft GDI+
Expand Down
2 changes: 0 additions & 2 deletions DeepSkyStacker/ExceptionHandling.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

#if defined(_WINDOWS)

#include <thread>
#include <inttypes.h>
#include "StackWalker.h"
#include "Ztrace.h"

Expand Down
4 changes: 2 additions & 2 deletions DeepSkyStacker/ExplorerBar.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
#include "ExplorerBar.h"
#include "ui/ui_ExplorerBar.h"

#include <Ztrace.h>
#include <zexcept.h>
#include "Ztrace.h"
#include "zexcept.h"
#include "DeepSkyStacker.h"
#include "ProcessingDlg.h"
#include "Workspace.h"
Expand Down
7 changes: 0 additions & 7 deletions DeepSkyStacker/FITSUtil.cpp
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
#include <stdafx.h>
#include <iostream>
#include <QSettings>
#include <omp.h>

// Ouch :(
#include <windows.h>

#include "resource.h"
#include "Workspace.h"
#include "FITSUtil.h"
Expand Down
6 changes: 0 additions & 6 deletions DeepSkyStacker/FITSUtil.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,11 @@
#define __FITSUTIL_H__

/* ------------------------------------------------------------------- */
#include <filesystem>
#include "cfa.h"
#include "DSSCommon.h"
#include "BitmapExtraInfo.h"
#include "fitsio.h"

// Want this out!
#include <atlstr.h>

namespace fs = std::filesystem;

#pragma comment(lib, "cfitsio.lib")

class CFITSHeader
Expand Down
1 change: 0 additions & 1 deletion DeepSkyStacker/File.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#include "stdafx.h"
#include <atlstr.h>
#include "file.h"

bool GetFileCreationDateTime(LPCTSTR szFileName, FILETIME& FileTime)
Expand Down
3 changes: 0 additions & 3 deletions DeepSkyStacker/FlatFrame.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
#include <stdafx.h>
#include <omp.h>
#include <atlstr.h>

#include "FlatFrame.h"
#include "Multitask.h"
#include "DSSProgress.h"
Expand Down
3 changes: 0 additions & 3 deletions DeepSkyStacker/MemoryBitmap.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
#include "ColorRef.h"
#include "Bayer.h"

// Not nice :(
#include <wtypesbase.h>

class CMultiBitmap;
class CMedianFilterEngine;
class CBitmapCharacteristics;
Expand Down
20 changes: 4 additions & 16 deletions DeepSkyStacker/QLinearGradientCtrl.cpp
Original file line number Diff line number Diff line change
@@ -1,23 +1,11 @@
// QLinearGradientCtrl.cpp
//
#include <algorithm>
using std::min;
using std::max;

#include <QColor>
#include <QDebug>
#include <QLinearGradient>
#include <QMouseEvent>
#include <QPainter>
#include <QPoint>
#include <QRect>
#include <QRegion>
#include <QWidget>

#include <Ztrace.h>

#include <stdafx.h>
#include "QLinearGradientCtrl.h"

#include "Ztrace.h"
#include "ZExcBase.h"

/////////////////////////////////////////////////////////////////////////////
// QLinearGradientCtrl

Expand Down
9 changes: 0 additions & 9 deletions DeepSkyStacker/QLinearGradientCtrl.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,6 @@
****************************************************************************/
// QLinearGradientCtrl : header file
//
#include <zexcept.h>

class QColor;
class QString;

#include <QWidget>
#include <QGradient>


#define GCW_AUTO -1

#define GC_SELCHANGE 1
Expand Down
1 change: 0 additions & 1 deletion DeepSkyStacker/RenameGroup.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
// RenameGroup.h : header file
//

#include <QDialog>
#include "ui/ui_RenameGroup.h"

namespace DSS
Expand Down
1 change: 1 addition & 0 deletions DeepSkyStacker/StackingDlg.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
#include "BatchStacking.h"
#include "StackRecap.h"
#include "ProcessingDlg.h"
#include "ZExcept.h"

#define dssApp DeepSkyStacker::instance()

Expand Down
Loading

0 comments on commit 3c67cd0

Please sign in to comment.