feat: LiquityV2 #419
Open
feat: LiquityV2 #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racts into feat/liquity-V2
| // when pulling max amount, we need to leave some WETH for gas compensation | ||
| if (isMaxPull) { | ||
| _params.collAmount = _collToken.pullTokensIfNeeded(_params.from, _params.collAmount); | ||
| if (_params.collAmount <= ETH_GAS_COMPENSATION) { |
There was a problem hiding this comment.
Do we need this check as it's going to revert on the underflow either way, also if the amount is slightly bigger it's still going to revert because it's not going to be enough collateral for min_debt.
There was a problem hiding this comment.
It’s not necessary; it was more of a sanity check to communicate more explicitly to the caller that WETH compensation is required and that the max uint256 will account for this. It’s true that this would need to be significantly higher than just the WETH gas compensation amount to cover the debt on the Liquity side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes following contracts:
Also, new strategies are introduced:
Things left to do:
SDK PR: defisaver/defisaver-sdk#122
AUTOMATION SDK PR: defisaver/automation-sdk#26