This repository has been archived by the owner on Oct 10, 2021. It is now read-only.
Remove tape-finished dependency #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sylvaincombes So is it ok to remove this dependency? Why do tests fail? I can't accept a PR that breaks tests. Please fix those up. |
|
@sylvaincombes you cannot just remove the dependency, you have to change the underlying code and see if it works: https://github.com/defunctzombie/zuul/blob/a232ad88560624a0275ba255fbf2085dc07d6d40/frameworks/tape/client.js |
sylvaincombes
force-pushed
the
master
branch
from
ed9007d
to
7721fd0
Compare
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove tape-finished dependency, see #223