Also serve CSS & images, auto-load CSS #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i would be a fan of this! |
|
Why not |
|
+1 |
1 similar comment
|
+1 |
|
is this going to be merged? |
|
+1 |
|
I think css should be served from |
|
Good point. |
|
I implemented this on my fork (https://github.com/fuadsaud/dotjs/tree/dev). The behaviour differs a little, but the idea is the same. I put up some specs to and everything seems to be working fine. I'd appreciate if anyone would help with testing it. |
|
See stewart/dotcss |
added 2 commits
May 6, 2014 12:37
|
If this get merged, please replace the .js directory with .dotjs and put there 3 folders called 'js', 'css' and 'images'. Would be the prettiest? |
added 2 commits
December 11, 2014 15:01
Conflicts: bin/djsd ext/dotjs.js ext/manifest.json
Use 127.0.0.1 because localhost mapped to an IPV6 address in /etc/hosts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Chris,
As discussed in #44 you're open to serving CSS & images but prefer a different location.
In this patch, CSS is served from ~/.js/css and images from ~/.jss/images. I've also updated the Chrome extension to auto-load CSS upon page load. No longer does one need to JS to insert style tags.
I hope you'll accept this patch and merge it in. It would also close #44.
Cheers,
@bartt