#101 add createdon etc attributes to context entity so they are avail… #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able to post operation plugins
TomMalow
requested changes
Aug 10, 2020
src/XrmMockupShared/Core.cs
Outdated
| return; | ||
| } | ||
|
|
||
| item1["createdon"] = postImage.GetAttributeValue<DateTime>("createdon"); |
There was a problem hiding this comment.
The code handles these 4 attributes in the same way. Can we maybe generalize? Maybe move the attributes to a list that the code iterates over and adds them to the item1. This will also make it easier to extend with additional attributes. Both me and @magesoe has a suspicion that there are other system attributes we need to do this with as well.
There was a problem hiding this comment.
I've made the solution more generic, with a list of system attribute names which is iterated over.
There was a problem hiding this comment.
Could #92 be resolved via this as well ?
|
Added in 1.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…able to post operation plugins