Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually disconnect on timeout #172

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Apr 21, 2015

  1. Actually disconnect on timeout

    lymph.core.connection.Connection pings the endpoint regularly
    to determine whether it is still live. `__init__` takes a
    `unresponsive_disconnect` parameter, which was however ignored
    so far. Similarly, the `idle_disconnect` parameter did not have
    any effect.
    
    This commit uses thees two parameters to do what they advertise,
    i.e. close the connection once the respective timeouts have been
    reached.
    
    To this end, the greenlet management logic was also changed, such
    that the monitoring greenlets now commit suicide when the connection
    `status == CLOSED` instead of being explicitely killed from `close()`.
    Without this change, the monitoring greenlet would inadvertently kill
    itself, leading to (very nonobvious) dead code and leaving a half-dead
    connection object still registered with the server.
    Drahflow committed Apr 21, 2015
    Configuration menu
    Copy the full SHA
    3584433 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2015

  1. Configuration menu
    Copy the full SHA
    b4d5b3a View commit details
    Browse the repository at this point in the history