Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-223] Pull secret element misplaced in pre upgrade CRD template #224

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

rafalw82
Copy link
Collaborator

@rafalw82 rafalw82 commented Apr 4, 2024

Purpose

Issue #223

imagePullSecrets element nested under containers instead of directly under spec level.

PR checklist

  • Add link to the issue
  • Choose Project
  • Choose PR label
  • New unit tests added
  • Modified code has meaningful comments
  • All TODOs are linked with the issues
  • All comments are resolved

Testing

Upgrade with Values.global.registrySecret specified.

Signed-off-by: rafalw82 <[email protected]>
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.41%. Comparing base (b69a72b) to head (0b0e043).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   60.41%   60.41%           
=======================================
  Files          10       10           
  Lines        1167     1167           
=======================================
  Hits          705      705           
  Misses        398      398           
  Partials       64       64           
Flag Coverage Δ
unittests 60.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafalw82 rafalw82 merged commit 78da5f8 into master Apr 8, 2024
4 checks passed
@rafalw82 rafalw82 deleted the bugfix-223-preupgrade branch April 8, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants