[issue-1122] removing done TODOs (#1127)

Makefile.validation

@@ -47,7 +47,7 @@ test-sanity-ci: hack-for-kind
 test-sanity-ci-k8s-122: hack-for-kind
 	cd tests && ${GO_ENV_VARS} CI=true CSI_VERSION=${CSI_VERSION} OPERATOR_VERSION=${OPERATOR_VERSION} go test ${LDFLAGS} -v e2e/baremetal_e2e_test.go -timeout 0 -ginkgo.focus="$(strip $(subst ',, ${SANITY_TEST}))" -ginkgo.v -ginkgo.progress -ginkgo.junit-report=reports/report.xml -ginkgo.skip="block" -all-tests  -kubeconfig=${HOME}/.kube/config -chartsDir ${CHARTS_DIR} > log.txt
 
-# Run commnity sanity tests for CSI. TODO https://github.com/dell/csi-baremetal/issues/298 Make sanity test work for expansion
+# Run commnity sanity tests for CSI.
 # TODO enable tests back - https://github.com/dell/csi-baremetal/issues/371
 test-sanity:
 #	${GO_ENV_VARS} SANITY=true go test test/sanity/sanity_test.go -ginkgo.skip \

api/v1/constants.go

@@ -46,7 +46,6 @@ const (
 	HealthSuspect = "SUSPECT"
 	HealthBad     = "BAD"
 
-	// TODO need to split constants by different packages
 	// Drive status
 	DriveStatusOnline  = "ONLINE"
 	DriveStatusOffline = "OFFLINE"
@@ -94,7 +93,7 @@ const (
 	//Volume expansion annotations
 	VolumePreviousStatus   = "expansion/previous-status"
 	VolumePreviousCapacity = "expansion/previous-capacity"
-	// TODO Mount status?
+
 	// Volume mode
 	ModeRAW     = "RAW"
 	ModeRAWPART = "RAW_PART"

cmd/scheduling/extender/main.go

@@ -62,7 +62,7 @@ var (
 	isPatchingEnabled = flag.Bool("isPatchingEnabled", false, "should enable readiness probe")
 )
 
-// TODO should be passed as parameters https://github.com/dell/csi-baremetal/issues/78
+// Registering stages
 const (
 	FilterPattern     string = "/filter"
 	PrioritizePattern string = "/prioritize"

pkg/base/k8s/cr_helper.go

@@ -121,7 +121,6 @@ func (cs *CRHelperImpl) DeleteACsByNodeID(nodeID string) error {
 	isError := false
 	for _, ac := range acList.Items {
 		if strings.EqualFold(ac.Spec.NodeId, nodeID) {
-			// todo fix linter issue - https://github.com/kyoh86/scopelint/issues/5
 			// nolint:scopelint
 			if err := cs.k8sClient.DeleteCR(context.Background(), &ac); err != nil {
 				ll.Warningf("Unable to delete AC %s: %s", ac.Name, err)
@@ -215,7 +214,6 @@ func (cs *CRHelperImpl) UpdateVolumesOpStatusOnNode(nodeID, opStatus string) err
 		if volume.Spec.OperationalStatus != opStatus {
 			volume.Spec.OperationalStatus = opStatus
 			ctxWithID := context.WithValue(context.Background(), base.RequestUUID, volume.Spec.Id)
-			// todo fix linter issue - https://github.com/kyoh86/scopelint/issues/5
 			// nolint:scopelint
 			if err := cs.k8sClient.UpdateCR(ctxWithID, &volume); err != nil {
 				ll.Errorf("Unable to update operational status for volume ID %s: %s", volume.Spec.Id, err)
@@ -293,7 +291,6 @@ func (cs *CRHelperImpl) UpdateDrivesStatusOnNode(nodeID, status string) error {
 	for _, drive := range drives {
 		if drive.Spec.Status != status {
 			drive.Spec.Status = status
-			// todo fix linter issue - https://github.com/kyoh86/scopelint/issues/5
 			// nolint:scopelint
 			if err := cs.k8sClient.UpdateCR(context.Background(), &drive); err != nil {
 				ll.Errorf("Unable to update status for drive ID %s: %s", drive.Spec.UUID, err)

pkg/base/util/common.go

@@ -58,7 +58,6 @@ func ConsistentRead(filename string, retry int, timeout time.Duration) ([]byte,
 // Receives string name of StorageClass
 // Returns string of CSI StorageClass
 func ConvertStorageClass(strSC string) string {
-	// TODO: use map or something else for such conversion https://github.com/dell/csi-baremetal/issues/84
 	sc := strings.ToUpper(strSC)
 	switch sc {
 	case api.StorageClassHDD,

pkg/controller/node/statemonitor.go

@@ -148,7 +148,6 @@ func (n *ServicesStateMonitor) UpdateNodeHealthCache() {
 				state   *serviceState
 				isExist bool
 			)
-			// todo when node is removed from cluster?
 			if state, isExist = n.nodeHealthMap[nodeID]; !isExist {
 				state = &serviceState{status: Unknown, time: currentTime}
 				// add pod to the map - no need to print warning message here since this is cache initialization

pkg/crcontrollers/reservation/reservationcontroller.go

@@ -115,7 +115,6 @@ func (c *Controller) handleReservationUpdate(ctx context.Context, log *logrus.En
 			volumes[i] = &v1api.Volume{Id: capacity.Name, Size: capacity.Size, StorageClass: capacity.StorageClass, StorageGroup: capacity.StorageGroup}
 		}
 
-		// TODO: do not read all ACs and ACRs for each request: https://github.com/dell/csi-baremetal/issues/89
 		acReader := capacityplanner.NewACReader(c.client, log, true)
 		acrReader := capacityplanner.NewACRReader(c.client, log, true)
 		capManager := c.capacityManagerBuilder.GetCapacityManager(log, acReader, acrReader)

pkg/node/volumemgr.go

@@ -298,7 +298,6 @@ func (m *VolumeManager) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R
 		// Failed drive shouldn't be cleaned up - to avoid data loss
 		case apiV1.Removed, apiV1.Failed:
 			// we need to update annotation on related drive CRD
-			// todo can we do polling instead?
 			ll.Infof("Volume %s is removed. Updating related", volume.Name)
 			// drive must be present in the system
 			drive, _ := m.crHelper.GetDriveCRByVolume(volume)
@@ -372,7 +371,6 @@ func (m *VolumeManager) updateVolumeAndDriveUsageStatus(ctx context.Context, vol
 		ll.Errorf("Unable to read drive CR, error: %v", err)
 		return ctrl.Result{Requeue: true}, err
 	}
-	// TODO add annotations for additional statuses?
 	if volumeStatus == apiV1.VolumeUsageReleased {
 		m.addVolumeStatusAnnotation(drive, volume.Name, apiV1.VolumeUsageReleased)
 	}
@@ -680,7 +678,6 @@ func (m *VolumeManager) updateDrivesCRs(ctx context.Context, drivesFromMgr []*ap
 			toCreateSpec := *drivePtr
 			toCreateSpec.NodeId = m.nodeID
 			toCreateSpec.UUID = uuid.New().String()
-			// TODO: what operational status should be if drivemgr reported drive with not a good health
 			toCreateSpec.Usage = apiV1.DriveUsageInUse
 			toCreateSpec.IsClean = true
 			isSystem, err := m.isDriveSystem(drivePtr.Path)
@@ -719,7 +716,6 @@ func (m *VolumeManager) updateDrivesCRs(ctx context.Context, drivesFromMgr []*ap
 			ll.Warnf("Set status %s for drive %v", apiV1.DriveStatusOffline, d.Spec)
 			previousState := d.DeepCopy()
 			toUpdate := d
-			// TODO: which operational status should be in case when there is drive CR that doesn't have corresponding drive from drivemgr response
 			toUpdate.Spec.Status = apiV1.DriveStatusOffline
 			if value, ok := d.GetAnnotations()[driveHealthOverrideAnnotation]; ok {
 				m.overrideDriveHealth(&toUpdate.Spec, value, d.Name)
@@ -1000,7 +996,6 @@ func (m *VolumeManager) handleDriveStatusChange(ctx context.Context, drive updat
 		prevHealthState := vol.Spec.Health
 		vol.Spec.Health = cur.Health
 		// initiate volume release
-		// TODO need to check for specific annotation instead
 		if vol.Spec.Health == apiV1.HealthBad || vol.Spec.Health == apiV1.HealthSuspect {
 			if vol.Spec.Usage == apiV1.VolumeUsageInUse {
 				vol.Spec.Usage = apiV1.VolumeUsageReleasing
@@ -1017,9 +1012,6 @@ func (m *VolumeManager) handleDriveStatusChange(ctx context.Context, drive updat
 				prevHealthState, vol.Spec.Health, cur.Health, cur.NodeId)
 		}
 	}
-	// Handle resources with LogicalVolumeGroup
-	// This is not work for the current moment because HAL doesn't monitor disks with LVM
-	// TODO: Handle disk health which are used by LVGs - https://github.com/dell/csi-baremetal/issues/88
 }
 
 func (m *VolumeManager) checkVGErrors(lvg *lvgcrd.LogicalVolumeGroup, drivePath string) {

pkg/node/volumemgr_test.go

@@ -112,7 +112,6 @@ var (
 		Children: nil,
 	}
 
-	// todo don't hardcode device name
 	lsblkSingleDeviceCmd = fmt.Sprintf(lsblk.CmdTmpl, "/dev/sda")
 
 	testDriveCR = drivecrd.Drive{

pkg/scheduler/extender/extender.go

@@ -215,7 +215,6 @@ func (e *Extender) PrioritizeHandler(w http.ResponseWriter, req *http.Request) {
 }
 
 // BindHandler does bind of a pod to specific node
-// todo - not implemented. Was used for testing purposes ONLY (fault injection)!
 func (e *Extender) BindHandler(w http.ResponseWriter, req *http.Request) {
 	sessionUUID := uuid.New().String()
 	ll := e.logger.WithFields(logrus.Fields{

pkg/scheduler/extender/extender_test.go

@@ -51,7 +51,6 @@ import (
 	"github.com/dell/csi-baremetal/pkg/metrics/common"
 )
 
-// todo review all tests. some might not be relevant
 var (
 	testLogger = logrus.New()
 	testUUID   = uuid.New().String()