Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-1133] Updating registries in makefile.validation #1134

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

Kacper-Michon-DELL
Copy link
Collaborator

@Kacper-Michon-DELL Kacper-Michon-DELL commented Apr 3, 2024

Purpose

Resolves #<#1133>

Upadate occurences of k8s.gcr.io to registry.k8s.io

PR checklist

  • Add link to the issue
  • Choose Project
  • Choose PR label
  • New unit tests added
  • Modified code has meaningful comments
  • All TODOs are linked with the issues
  • All comments are resolved

Testing

Provide test details

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.33%. Comparing base (068a53e) to head (3a59eeb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1134   +/-   ##
=======================================
  Coverage   70.32%   70.33%           
=======================================
  Files         106      106           
  Lines       10483    10483           
=======================================
+ Hits         7372     7373    +1     
+ Misses       2812     2811    -1     
  Partials      299      299           
Flag Coverage Δ
unittests 70.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kacper Michon <kacper-michon>
@Kacper-Michon-DELL Kacper-Michon-DELL merged commit cd52eee into master Apr 3, 2024
5 of 6 checks passed
@Kacper-Michon-DELL Kacper-Michon-DELL deleted the issue-1133 branch April 3, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants