-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manager reset resource #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Storage Datasource migration * Docs * Fixing tests after merge * Lint fix
* Firmware Inventory datasource * Firmware Inventory datasource * formatting issue fixed * doc issuue fixed * comments addressed
* bios resource Migrated * comments addressed
* System boot datasource migration to TPF * linting fix * fixed doc * removed commented code
* volume migration to tpf * Storage volume migration to TPF * Updated volume model * Fixed linting * fixed md * fixed applytime onreset for create * linting fix * code restructuring * addressed review comments --------- Co-authored-by: Krishnan-Priyanshu <[email protected]>
prajwalpatil25
requested review from
Sakshi-dell,
Krishnan-Priyanshu and
rounak-adhikary
November 17, 2023 17:50
Krishnan-Priyanshu
approved these changes
Nov 24, 2023
rounak-adhikary
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented manager reset resource through which iDRAC reset operation can be performed.