fix: jsonwriter should checkpoint by default #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix aimed to enable jsonwriter to checkpoint in accordance with delta.checkpointInterval. It changes the default commitbuilder to set a post_commit_hook so that checkpointing will be done by default. Potentially we could also expose CommitProperties as an argument to flush_and_commit, but that would require a change to the function signature and would be a breaking change. Signed-off-by: Justin Jossick <[email protected]>
jusjosj
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
rtyler
approved these changes
Nov 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2993 +/- ##
==========================================
+ Coverage 72.32% 72.37% +0.05%
==========================================
Files 128 128
Lines 40420 40467 +47
Branches 40420 40467 +47
==========================================
+ Hits 29233 29289 +56
Misses 9308 9308
+ Partials 1879 1870 -9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix aimed to enable jsonwriter to checkpoint in accordance with delta.checkpointInterval. It changes the default commitbuilder to set a post_commit_hook so that checkpointing will be done by default. Potentially we could also expose CommitProperties as an argument to flush_and_commit, but that would require a change to the function signature and would be a breaking change.
Related Issue(s)