fix comments

delta-io · Sep 27, 2024 · 3be3a4c · 3be3a4c
1 parent 8f7d379
commit 3be3a4c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/server/src/main/scala/io/delta/standalone/internal/DeltaSharedTable.scala b/server/src/main/scala/io/delta/standalone/internal/DeltaSharedTable.scala
@@ -505,7 +505,7 @@ class DeltaSharedTable(
           null
         }
         // For backwards compatibility, return an `endStreamAction` object only when
-        // `includeRefreshToken` is true or `maxFiles` is specified
+        // `includeRefreshToken` is true, `maxFiles` is specified or includeEndStreamAction.
         filteredFiles ++ {
           if (includeRefreshToken || maxFiles.isDefined || includeEndStreamAction) {
             Seq(getEndStreamAction(nextPageTokenStr, minUrlExpirationTimestamp, refreshTokenStr))
@@ -646,10 +646,9 @@ class DeltaSharedTable(
           case _ => ()
         }
       }
-    // Return an `endStreamAction` object only when `maxFiles` is specified for
-    // backwards compatibility.
+    // Return an `endStreamAction` object only when `maxFiles` or includeEndStreamAction is
+    // specified for backwards compatibility.
     if (maxFilesOpt.isDefined || includeEndStreamAction) {
-      // TODO(Ask why nextPageTokenStr is always null
       actions.append(getEndStreamAction(null, minUrlExpirationTimestamp))
     }
     actions.toSeq

diff --git a/server/src/test/scala/io/delta/sharing/server/DeltaSharingServiceSuite.scala b/server/src/test/scala/io/delta/sharing/server/DeltaSharingServiceSuite.scala
@@ -189,8 +189,7 @@ class DeltaSharingServiceSuite extends FunSuite with BeforeAndAfterAll {
       if (includeEndStreamAction) {
         expectedHeader += s";includeendstreamaction=true"
       }
-      assert(responseCapabilities == expectedHeader,
-        s"Incorrect response format: $responseCapabilities")
+      assert(responseCapabilities == expectedHeader, s"Incorrect header: $responseCapabilities")
     }
     val deltaTableVersion = connection.getHeaderField("Delta-Table-Version")
     expectedTableVersion.foreach { v =>